fix(cards): keep the blank line between the metadata list and the next heading - #71
Merged
Merged
Conversation
…t heading
Dry-running the ltx-2.3 card refresh showed it would publish
- **Model version:** 2.3.0
## Usage
with no blank line — a markdown list running into a heading. `{% endif -%}`
eats it, so the blank line has to be literal and inside the block, the same
shape as the links and LoRA sections. Introduced when card generation moved to
Jinja (2671caf); the published cards predate that and still have the blank
line.
Checked in all five shapes — metadata with and without a Usage section, a
Usage section without metadata, neither, and quantized — since a literal blank
line in the wrong place also appears when the block is absent.
Also pairs `- **Label:** value` lines in the dry run's loss warning. The ltx
refresh rewrites "Transformer variants: distilled, dev" as "dev, distilled,
distilled-1.1", which was being reported as content disappearing. A warning
that fires on a correction trains you to ignore it.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TaEHdLNyZuqjxqGmZ73JG9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by dry-running the
ltx-2.3card refresh before pushing it, not by reading the template.1. A list running into a heading
The refresh would have published:
No blank line — malformed markdown.
{% endif -%}eats it, so the blank line has to be literal and inside the block, the same shape as the fix applied to the links and LoRA sections in #60.Introduced when card generation moved to Jinja (
2671caf); the published cards predate that and still have the blank line, which is why regenerating showed it as a removal.Checked in all five shapes — metadata with and without a Usage section, a Usage section without metadata, neither, and quantized — because a literal blank line in the wrong place also appears when the block is absent. That is the failure mode of the previous attempt at this fix.
2. A warning that fired on a correction
The ltx refresh rewrites
which the dry run reported as content disappearing. The loss warning now pairs
- **Label:** valuelines on their label, as it already did for file entries. A warning that fires on an improvement trains you to ignore it, which defeats the point of having one.Verification
755 tests pass;
ruffandtyclean.These fixes are already load-bearing
Four cards were published from this branch after dry-running each one:
matrix-game-3.0-mlxgoogle/umt5-xxl/*tokenizer filesltx-2.3-mlx,-q4,-q8Each real diff matched its dry run exactly, with no losses.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TaEHdLNyZuqjxqGmZ73JG9