Give a highlighted fixture back its date, and let the folded sheet have one - #16
Merged
Merged
Conversation
…ve one A tooltip has room for a headline and a detail, and the split rewrite spent the detail on the mirror archive. So a cell highlighted as an upcoming first meeting said "first meeting coming up" and stopped there — the date and the competition, the only reason to look at a yellow cell, were gone. A played pair quietly lost the years it has met between, and a pre-debut cell the year of its first match. The cell's own archive keeps its detail now and the mirror is appended, not substituted, so a summary is three lines where it has three things to say. summaryHtml renders as many as it is given rather than exactly two. Upcoming was also dead on the folded sheet: the toggle greyed out with the never-played one, on the grounds that both were single-archive ideas. Only one of them is. Never-played moves the meetings ramp, and a folded cell carries the four-way key instead, whose colours are fixed — but a pairing that has never met in either game and has a date booked is exactly what the folded sheet is for. It highlights those 23 pairs now, on the same rule the unfolded halves use: yellow replaces never, and a pair that has already met in one game keeps the colour that says so. The folded tooltip names the fixture too. While there: the folded key never named the three empties the sheet can also paint, and the fixtures feed still described itself as covering both games "whichever dataset the grid is set to", which has not been a thing to set since the fold landed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ktg1PkqJw6sBz1Wh5qyDsh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things I broke in #14, found by looking at what Upcoming actually does now.
The tooltip lost the date
A summary has room for a headline and a detail, and the split rewrite spent the detail on the mirror archive. So a cell highlighted as an upcoming first meeting said "first meeting coming up" and stopped there — the date and the competition, the only reason to look at a yellow cell, were gone.
It was not only Upcoming. The detail line carried three different facts, and every one of them was being dropped:
first meeting coming up·2026-09-23 · International FriendlyMen's: first meeting coming up·Women's: never playedMen's: first meeting coming up·2026-09-23 · International Friendly·Women's: never played110 meetings·1914–2025Men's: 110 meetings·Women's: 15 meetingsMen's: 110 meetings·1914–2025·Women's: 15 meetingshad not debuted by 1930·first match 2007Men's: had not debuted by 1930·Women's: …The cell's own archive keeps its detail and the mirror is appended rather than substituted.
summaryHtmlrenders as many lines as it is given instead of exactly two, so the tooltip, the peek card and the live region all pick it up.Upcoming was dead on the folded sheet
The toggle greyed out alongside Never-played, on the grounds that both were single-archive ideas. Only one of them is.
Never-played moves the meetings ramp, and a folded cell carries the four-way key instead, whose colours are fixed — it genuinely has nothing to change there. But a pairing that has never met in either game and has a date booked is exactly what the folded sheet is for. It highlights those now, on the same rule the unfolded halves use: yellow replaces never, and a pair that has already met in one game keeps the colour that says so.
Of the 36 scheduled first meetings (34 distinct pairs — two have a fixture booked in both games), 23 have never met in either and light up folded; the other 11 keep their men's-only or women's-only colour. The folded tooltip names the fixture either way.
Two bits of rot, while there
Testing
Verified in Chromium, unfolded and folded:
python -m unittest discover -s tests— 37 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ktg1PkqJw6sBz1Wh5qyDsh
Generated by Claude Code