Skip to content

Give a highlighted fixture back its date, and let the folded sheet have one - #16

Merged
dgoodenough merged 1 commit into
mainfrom
claude/mirror-split-games-view-jsy6v0
Sep 16, 2026
Merged

dgoodenough merged 1 commit into
mainfrom
claude/mirror-split-games-view-jsy6v0

Conversation

@dgoodenough

Copy link
Copy Markdown
Owner

Two things I broke in #14, found by looking at what Upcoming actually does now.

The tooltip lost the date

A summary has room for a headline and a detail, and the split rewrite spent the detail on the mirror archive. So a cell highlighted as an upcoming first meeting said "first meeting coming up" and stopped there — the date and the competition, the only reason to look at a yellow cell, were gone.

It was not only Upcoming. The detail line carried three different facts, and every one of them was being dropped:

cell before #14 after #14 now
upcoming first meeting coming up · 2026-09-23 · International Friendly Men's: first meeting coming up · Women's: never played Men's: first meeting coming up · 2026-09-23 · International Friendly · Women's: never played
played 110 meetings · 1914–2025 Men's: 110 meetings · Women's: 15 meetings Men's: 110 meetings · 1914–2025 · Women's: 15 meetings
pre-debut had not debuted by 1930 · first match 2007 Men's: had not debuted by 1930 · Women's: … all three

The cell's own archive keeps its detail and the mirror is appended rather than substituted. summaryHtml renders as many lines as it is given instead of exactly two, so the tooltip, the peek card and the live region all pick it up.

Upcoming was dead on the folded sheet

The toggle greyed out alongside Never-played, on the grounds that both were single-archive ideas. Only one of them is.

Never-played moves the meetings ramp, and a folded cell carries the four-way key instead, whose colours are fixed — it genuinely has nothing to change there. But a pairing that has never met in either game and has a date booked is exactly what the folded sheet is for. It highlights those now, on the same rule the unfolded halves use: yellow replaces never, and a pair that has already met in one game keeps the colour that says so.

Of the 36 scheduled first meetings (34 distinct pairs — two have a fixture booked in both games), 23 have never met in either and light up folded; the other 11 keep their men's-only or women's-only colour. The folded tooltip names the fixture either way.

Two bits of rot, while there

  • The folded key named four colours; the sheet paints seven. Upcoming, not-yet-debuted and never-played-anyone are in it now.
  • The fixtures feed still described itself as covering both games "whichever dataset the grid is set to" — not a thing to set since the fold landed.

Testing

Verified in Chromium, unfolded and folded:

  • Upcoming cells carry date and competition again, in both halves; played pairs carry their year range; pre-debut cells carry their first-match year; never-played-anyone and self cells are unchanged.
  • Scrubbed to 1930 as well as at the present.
  • Folded: 384px of highlight where there was none, the toggle live, Never-played still correctly disabled, and toggling off clears it.
  • The peek card renders the extra line.
  • No console errors.

python -m unittest discover -s tests — 37 passed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ktg1PkqJw6sBz1Wh5qyDsh


Generated by Claude Code

…ve one

A tooltip has room for a headline and a detail, and the split rewrite spent
the detail on the mirror archive. So a cell highlighted as an upcoming first
meeting said "first meeting coming up" and stopped there — the date and the
competition, the only reason to look at a yellow cell, were gone. A played
pair quietly lost the years it has met between, and a pre-debut cell the year
of its first match.

The cell's own archive keeps its detail now and the mirror is appended, not
substituted, so a summary is three lines where it has three things to say.
summaryHtml renders as many as it is given rather than exactly two.

Upcoming was also dead on the folded sheet: the toggle greyed out with the
never-played one, on the grounds that both were single-archive ideas. Only
one of them is. Never-played moves the meetings ramp, and a folded cell
carries the four-way key instead, whose colours are fixed — but a pairing
that has never met in either game and has a date booked is exactly what the
folded sheet is for. It highlights those 23 pairs now, on the same rule the
unfolded halves use: yellow replaces never, and a pair that has already met
in one game keeps the colour that says so. The folded tooltip names the
fixture too.

While there: the folded key never named the three empties the sheet can also
paint, and the fixtures feed still described itself as covering both games
"whichever dataset the grid is set to", which has not been a thing to set
since the fold landed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ktg1PkqJw6sBz1Wh5qyDsh
@dgoodenough
dgoodenough merged commit a75b080 into main Sep 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants