Quieten the crease labels, and say which table the rank comes from - #15
Merged
Merged
Conversation
MEN'S and WOMEN'S were set at a fifteenth of the grid's width, which made them a headline stamped across the data rather than a note about the fold. They are a caption now: the panel's own label size and colour, pushed out towards the corners, haloed thinly enough to survive the red field and the green ramp without reading as a badge. render_hero.py follows, so the README image is quiet in the same way. The share card is unchanged — it never drew them. The sheet also carries two FIFA rankings, and which of them orders it is not a question the sheet can answer for you. *Rank by* now reads the men's table, the women's, the average of the two, or — the default, and what the fold shipped with — whichever of a team's two ranks is better. It sits under Sort and greys out over the two orders that read no ranking table at all. An average is an average only where there are two numbers to take it of, so a team the chosen table does not rank sorts last, as the women's-only teams already did. The rank printed beside a team in the panel moves with the setting and names it on hover, and lands between the tables often enough to want a decimal. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ktg1PkqJw6sBz1Wh5qyDsh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups to #14.
The crease labels are a caption now
MEN'S and WOMEN'S were set at a fifteenth of the grid's width — a headline stamped across the data rather than a note about the fold. They now use the panel's own label size and colour (
--ink-2, 10–20px rather than 12–58px), sit further out towards the corners, and are haloed thinly enough to survive both the red field and the green ramp without reading as a badge.render_hero.pyfollows, so the README image is quiet in the same way. The share card is unchanged — it never drew them.clamp(12, L/15, 58)clamp(10, L/40, 20)--inkat 62%--ink-2size / 2.5size / 4Rank by
The sheet carries two FIFA rankings, and which of them orders it is not a question the sheet can answer for you. A Rank by select under Sort now reads:
It greys out (control and label) under Total matches played and Alphabetical, the two orders that read no ranking table — an enabled control that does nothing is the thing this panel already goes out of its way to avoid.
An average is an average only where there are two numbers to take it of, so a team the chosen table does not rank sorts last — as the ~14 members with no women's ranking already did. The default always has a number for every team.
The rank printed beside a team in the panel moves with the setting, names it on hover, and lands between the tables often enough to want a decimal (Australia is
#21.5on the average). State is in the URL as?rank=men|women|avg.Testing
Verified in Chromium:
#21.5, and the chip's tooltip names the table.matchesandalpha, enables underrankandconfed.?rank=avg&sort=rankround-trips;?fold=1&rank=womencarries both.python -m unittest discover -s tests— 37 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ktg1PkqJw6sBz1Wh5qyDsh
Generated by Claude Code