Repository navigation
Keep PySCF dispersion state consistent across molecule resets - #248
Merged
Merged
Conversation
Co-authored-by: awvwgk <28669218+awvwgk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix PySCF wrapper to reset molecule in scanner
Keep PySCF dispersion state consistent across molecule resets
Oct 26, 2026
awvwgk
marked this pull request as ready for review
October 26, 2026 19:11
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 63.39% 63.34% -0.06%
==========================================
Files 47 47
Lines 6844 6850 +6
Branches 2435 2435
==========================================
Hits 4339 4339
- Misses 1191 1197 +6
Partials 1314 1314 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: awvwgk <28669218+awvwgk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PySCF dispersion corrections must track molecule changes during resets and scanner calls. No-argument resets currently clear the dispersion molecule, while Hessian resets are unimplemented.