feat: Implement shell completions - #697
Open
adamspofford-dfinity wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds shell completion generation and automatic npm installation.
Changes:
- Adds completion generation for five shells.
- Installs common completions during npm postinstall.
- Updates dependencies and documentation.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
npm/icp-cli/postinstall.js |
Invokes completion installation. |
npm/icp-cli/completions.js |
Generates and installs scripts. |
docs/reference/cli.md |
Documents the new command. |
docs/guides/installation.md |
Adds installation guidance. |
crates/icp-cli/src/main.rs |
Handles completions before setup. |
crates/icp-cli/src/commands/mod.rs |
Registers the subcommand. |
crates/icp-cli/src/commands/completions.rs |
Implements completion generation. |
crates/icp-cli/Cargo.toml |
Adds crate dependency. |
CHANGELOG.md |
Records the feature. |
Cargo.toml |
Adds workspace dependency. |
Cargo.lock |
Locks dependency changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+33
to
+35
| pub(crate) fn exec(args: &CompletionsArgs) { | ||
| let mut command = Cli::command(); | ||
| generate(args.shell, &mut command, "icp", &mut io::stdout()); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
adamspofford-dfinity
marked this pull request as ready for review
August 7, 2026 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.