Add HTTP Digest authentication (RFC 7616)#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Digest Access Authentication credential policy, completing the SDK's auth coverage alongside Bearer, Basic, and API-key.
DigestAuthPolicyis challenge-driven, as the protocol requires: it sends the request, and on a401carrying aWWW-Authenticate: Digestchallenge it computes the keyed response and retries once. It then caches the challenge and applies Digest preemptively on later requests with an incrementing nonce count, re-challenging only when the server rotates the nonce. At most two sends per call, so the path is bounded.-sessvariants, withqop=author no qop — covering effectively all real Digest servers.auth-int, SHA-512-256,userhash, and multi-scheme single-header challenges are intentionally out of scope.auth.ErrInsecureTransporton a non-httpsURL).WithDigestAuth(username, password), placed at the auth stage. Precedence when several auth options are set:WithCredential→WithBasicAuth→WithAPIKey→WithDigestAuth.Test plan
ErrInsecureTransportbefore any hashing=, empty headers)WithDigestAuththrough the clientgofmt -l .clean,go vet ./...clean,go test -race ./...green across all packages🤖 Generated with Claude Code