Auth: pluggable token cache (WithTokenCache)#15
Merged
Conversation
TokenCache interface + InMemoryTokenCache default; BearerTokenPolicy refactored to use it (behaviour preserved); WithTokenCache umbrella option for sharing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ests; doc shared-cache refresh Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
BearerTokenPolicy's token cache pluggable so multiple clients can share(or persist) bearer tokens, instead of each policy caching its own.
What's included
auth.TokenCache— aGet/Setinterface keyed by the scope set, with aconcurrency-safe
InMemoryTokenCachedefault.auth.NewBearerTokenPolicyWithCache(cred, cache, scopes...)— injects ashared cache.
NewBearerTokenPolicyis unchanged and uses a private in-memorycache, so existing behavior is identical.
dexpace.WithTokenCache(cache)— shares a cache across the bearer policythat
WithCredentialinstalls.The per-policy refresh lock and the five-minute freshness window are unchanged. A
shared cache populated by one policy is reused by others via the freshness check;
cross-policy single-flight is intentionally not performed (documented).
Background
One of the items deferred from the auth-breadth roadmap subsystem.
Behavior changes
None —
NewBearerTokenPolicyand the default client path behave exactly as before(the existing caching test passes unchanged).
Test plan
go build ./...go vet ./...gofmt -l .(clean)go test -race ./...(all packages pass)-race), and scope-key isolation;existing per-policy caching preserved (1 fetch for 3 requests); a near-expiry
token is re-fetched (freshness window); two policies and two clients sharing a
cache fetch the token once.
🤖 Generated with Claude Code