Expand .dockerignore to reduce unnecessary cache invalidation#4797
Open
singhvishalkr wants to merge 1 commit into
Open
Expand .dockerignore to reduce unnecessary cache invalidation#4797singhvishalkr wants to merge 1 commit into
singhvishalkr wants to merge 1 commit into
Conversation
Member
|
@singhvishalkr thanks for the PR! Could you please run |
The Dockerfile copies the entire source tree with COPY . ., which means any change to .git/, docs/, examples/, or other non-build files invalidates the Docker layer cache. Add exclusions for: - .git/ (changes on every commit) - Documentation and examples - Editor/tool configs - Development-only files Signed-off-by: Vishal Kumar Singh <vishal.kr.singh2021@gmail.com>
singhvishalkr
force-pushed
the
fix-dockerignore-cache-invalidation
branch
from
1e12bae to
0dc9ccf
Compare
Author
|
Signed off the commit and force-pushed 0dc9ccf. The DCO check should rerun on the updated branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1968
The Dockerfile uses
COPY . .which copies the entire source tree into the build context. This means any change to files that aren't needed for the build (like.git/,docs/,examples/) still invalidates the Docker layer cache.This is particularly noticeable with
.git/-- every new commit, branch, or tag causes a full rebuild even though the actual source code hasn't changed.The fix expands
.dockerignoreto exclude:.git/and.gitignoredocs/,examples/, and Markdown files.github/,.editorconfig, etc.)docker-compose*.yaml,config.dev.yaml)DockerfileitselfThis keeps the build context minimal and focused on what the image actually needs: Go source files, dependencies (
go.mod/go.sum),config.docker.yaml, andweb/templates.