[devsy-app]

Summary

Replaces repeated "ubuntu", "debian", and "raspbian" string literals in pkg/dockerinstall with the existing named constants DistroUbuntu, DistroDebian, and DistroRaspbian, resolving the goconst "but such constant already exists" findings.

Linter + category

• Linter: golangci-lint → goconst
• Category: "but such constant already exists" findings (string literals duplicated where an exported constant with the same value is already defined)

Findings fixed

Resolved 3 goconst "already exists" package-level findings, across 21 literal replacements (no behavioral change — each literal is replaced with the constant of identical value):

• "ubuntu" (8 occurrences) → DistroUbuntu
• "debian" (6 occurrences) → DistroDebian
• "raspbian" (3 occurrences) → DistroRaspbian

Files touched (single package, pkg/dockerinstall):

• pkg/dockerinstall/install.go — switch case list
• pkg/dockerinstall/validator.go — supported-distro map keys
• pkg/dockerinstall/detector_test.go — s.Equal assertions + Distro table literals

The remaining occurrences in validator_test.go were intentionally left as literals so the change stays minimal and does not surface adjacent pre-existing goconst ("make it a constant") findings for 22.04/stretch as new. After this change each of the three strings appears fewer than 3 times as a literal, so the "already exists" findings no longer fire.

Fix method

Mechanical — literal-for-named-constant substitution. The constants already exist in pkg/dockerinstall/constants.go; no new constants, no logic changes. Raw-string /etc/os-release test fixtures (which simulate file content, not Go literals) were deliberately left untouched.

Verification

• task cli:format — clean
• task cli:lint:ci — 0 new issues (--new-from-patch against origin/main)
• go test ./pkg/dockerinstall/... — ok (passes)
• task cli:test — all packages pass except the known pre-existing pkg/git TestRepoClone* failures (a stale assertion on origin/main, unrelated to this change — verified failing on a clean checkout of main)

This PR was created by an AI agent as part of an automated daily lint fix job.

[netlify]

✅ Deploy Preview for images-devsy-sh canceled.

Name	Link
🔨 Latest commit	1844b1e
🔍 Latest deploy log	https://app.netlify.com/projects/images-devsy-sh/deploys/6a79a3d8eca1cf00083ce330

[netlify]

✅ Deploy Preview for devsydev canceled.

Name	Link
🔨 Latest commit	1844b1e
🔍 Latest deploy log	https://app.netlify.com/projects/devsydev/deploys/6a79a3d95e55e10008164dd3

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}