Repository navigation
refactor(cmd/config): use names pkg flags - #978
Merged
Merged
Conversation
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 2 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd/ subdirectory reviewed
cmd/config/— specificallycmd/config/apply.goandcmd/config/apply_test.go.Issue found
cmd/config/apply.godefined four local flag-name string constants:flagApplyContainerflagApplyConfigflagApplyWorkspaceFolderflagApplyDockerPathThese duplicated the canonical flag names already exported by
pkg/flags/names. The sibling filecmd/config/read.goin the same package already uses the sharednames.*constants for its flags, soapply.gowas an inconsistency withincmd/config: the same flag name strings were maintained in two places (the local constants andpkg/flags/names). Keeping flag names in a single canonical package is the repo convention (seecmd/flag_aliases_test.go, which asserts flag aliases againstpkg/flags/names).Minimal change
flagApply*constants fromcmd/config/apply.go.github.com/devsy-org/devsy/pkg/flags/namesimport and replaced usages withnames.Container,names.Config,names.WorkspaceFolder, andnames.DockerPath.cmd/config/apply_test.goto reference the samenames.*constants (added the import, replaced theflagApply*references).No behavioral change: the underlying flag name strings are identical, so the CLI flags, help text, and flag aliases are unchanged.
Verification performed
task cli:format— clean (no changes to modified files).task cli:lint:ci— 0 issues (new-from-patch againstorigin/main).task cli:test—cmd/configpackage passes. The only failing package ispkg/git(TestRepoClone*), which is a known pre-existing failure onorigin/main(stale assertion, not caused by this change). This change does not touchpkg/git.This PR was created by an AI agent as part of an automated daily CLI review job.