Repository navigation
fix: rename max var shadowing builtin - #975
Merged
Merged
Conversation
Codefactor flagged the local variable 'max' in detectLanguageByExtension as a redefinition of the built-in function (pkg/language/language.go). Rename it to maxCount so the loop tracks the highest file count without shadowing the builtin max.
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
skevetter
marked this pull request as ready for review
August 10, 2026 00:21
skevetter
enabled auto-merge (squash)
August 10, 2026 00:21
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codefactor issue fix
Redefinition of built-in function max(Maintainability) —pkg/language/language.go, lines 221 & 225pkg/language/language.go:221(functiondetectLanguageByExtension)Problem
Codefactor flagged the local variable
maxdeclared indetectLanguageByExtensionas a redefinition of the built-inmaxfunction, shadowing the builtin and reducing maintainability/clarity.Fix
Renamed the local variable
max→maxCount(and its two references in the comparison loop). This removes the builtin shadowing without changing any behavior — the loop still tracks the programming language with the highest file count, using the same tie-break on lexicographic ordering.Single-file, ~4-line change, no API or behavioral impact.
Verification
task cli:lint:ci— 0 new issues (clean)task cli:format— passed (no formatting changes needed)go build ./pkg/language/...+go vet ./pkg/language/...— OKtask cli:test— pkg/language has no test files; the only failing package ispkg/git(TestRepoClone*), a known pre-existing failure onorigin/mainunrelated to this change (this PR touchespkg/language, notpkg/git).Commit authenticated as the Devsy GitHub App (verified=true, SHA
93726e7).This PR was created by an AI agent as part of an automated daily Codefactor issue fix job.