Repository navigation
fix(ui): add sr-only labels to log buttons - #964
Merged
Merged
Conversation
## Problem In `pages/WorkspaceDetailPage.svelte`, three icon-only buttons in the workspace Logs section — "Copy output", "Copy log", and "Delete log" — had only a hover `Tooltip` for labeling and no accessible name. Screen-reader users heard only an unnamed "button", since a tooltip is not an accessible name and these icons carry no text. Other icon-only buttons in the same file already follow the convention of adding `<span class="sr-only">…</span>`. ## Change Add a `<span class="sr-only">` label to each of the three icon-only buttons (Copy output, Copy log, Delete log) in the log-files/output area, matching the existing pattern used elsewhere in the file (e.g. the rename, copy SSH, and more-actions buttons). Purely additive markup — no logic, styling, or behavior changes. ## Why it's safe / reviewable in <15 min - One file, three added lines (`+3`). - No JS/TS, store, routing, IPC, or CSS changes. - `sr-only` is visually hidden (existing utility), so the rendered UI is unchanged. - Uses the exact same idiom already established in this file. ## Verification - `npm install --ignore-scripts` — succeeded. - `npm run check` (svelte-check / type check) — **0 errors, 0 warnings**. - `npx vitest run` — **48/48 tests passed**. (32 unrelated "errors" are a pre-existing jsdom/undici `markAsUncloneable is not a function` incompatibility with the local Node v20 runtime; the repo targets Node 24 per CI. These occur at environment setup, not in test execution, and are not affected by markup changes.) - `task cli:format` — clean. - `task cli:lint:ci` — **0 issues**. - `npx biome check` on the edited file could not complete in this environment (hangs under Node v20, same toolchain incompatibility as the vitest environment errors); svelte-check covers the Svelte/a11y validation. This PR was created by an AI agent as part of an automated daily UI polish job.
✅ Deploy Preview for images-devsy-sh canceled.
|
✅ Deploy Preview for devsydev canceled.
|
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
pages/WorkspaceDetailPage.svelte, three icon-only buttons in the workspace Logs section — "Copy output", "Copy log", and "Delete log" — had only a hoverTooltipfor labeling and no accessible name. Screen-reader users heard only an unnamed "button", since a tooltip is not an accessible name and these icons carry no text. Other icon-only buttons in the same file already follow the convention of adding<span class="sr-only">…</span>.Change
Add a
<span class="sr-only">label to each of the three icon-only buttons (Copy output, Copy log, Delete log) in the log-files/output area, matching the existing pattern used elsewhere in the file (e.g. the rename, copy SSH, and more-actions buttons). Purely additive markup — no logic, styling, or behavior changes.Why it's safe / reviewable in <15 min
+3).sr-onlyis visually hidden (existing utility), so the rendered UI is unchanged.Verification
npm install --ignore-scripts— succeeded.npm run check(svelte-check / type check) — 0 errors, 0 warnings.npx vitest run— 48/48 tests passed. (32 unrelated "errors" are a pre-existing jsdom/undicimarkAsUncloneable is not a functionincompatibility with the local Node v20 runtime; the repo targets Node 24 per CI. These occur at environment setup, not in test execution, and are not affected by markup changes.)task cli:format— clean.task cli:lint:ci— 0 issues.npx biome checkon the edited file could not complete in this environment (hangs under Node v20, same toolchain incompatibility as the vitest environment errors); svelte-check covers the Svelte/a11y validation.This PR was created by an AI agent as part of an automated daily UI polish job.