Skip to content

test(e2e): cover matchIPv4 IP-selection helper #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 2 commits into from
Aug 9, 2026
Merged

test(e2e): cover matchIPv4 IP-selection helper #961

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4721a2
test(e2e): cover matchIPv4 IP-selection helper
devsy-app[bot] Aug 9, 2026
5fc174d
style: update comments
skevetter Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions e2e/framework/server_utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
package framework

import (
"net"
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestMatchIPv4_IPNet_ClassC(t *testing.T) {
_, ipNet, err := net.ParseCIDR("192.168.1.0/24")
require.NoError(t, err)
assert.Equal(t, "192.168.1.0", matchIPv4(ipNet))
}

func TestMatchIPv4_IPNet_ClassA(t *testing.T) {
_, ipNet, err := net.ParseCIDR("10.0.0.0/8")
require.NoError(t, err)
assert.Equal(t, "10.0.0.0", matchIPv4(ipNet))
}

func TestMatchIPv4_IPNet_ClassB_NotSelected(t *testing.T) {
_, ipNet, err := net.ParseCIDR("172.16.0.0/16")
require.NoError(t, err)
assert.Empty(t, matchIPv4(ipNet))
}

func TestMatchIPv4_IPAddr_ClassC(t *testing.T) {
addr := &net.IPAddr{IP: net.ParseIP("192.168.1.5")}
require.NotNil(t, addr.IP)
assert.Equal(t, "192.168.1.5", matchIPv4(addr))
}

func TestMatchIPv4_IPv6_NotSelected(t *testing.T) {
_, ipNet, err := net.ParseCIDR("fd00::1/64")
require.NoError(t, err)
assert.Empty(t, matchIPv4(ipNet))
}

func TestMatchIPv4_UnknownAddrType_NotSelected(t *testing.T) {
assert.Empty(t, matchIPv4(&net.UDPAddr{IP: net.ParseIP("192.168.1.5"), Port: 1234}))
}
Loading