Repository navigation
fix(desktop): raise workspace status IPC timeout from 5s to 15s - #850
Merged
Merged
Conversation
A too-tight 5s timeout on the workspace_status IPC call could cause container status checks to time out on slower providers, causing the call to error out and skip the provisioning-status override. The frontend silently swallows that failure and keeps the previously cached status, so the workspace detail/list pages could get stuck showing a stale "NotFound" badge instead of the real status.
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesWorkspace status timeout
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace_statusIPC handler hardcoded a 5s--timeoutfordevsy workspace status, far tighter than the CLI's own 30s default.fetchStatusesinworkspaces.ts) silently swallows that failure and keeps the last cached status, so the workspace list/detail pages can get stuck showing a stale "NotFound" badge instead of the real status.Summary by CodeRabbit