Skip to content

fix(desktop): raise workspace status IPC timeout from 5s to 15s - #850

Merged
skevetter merged 1 commit into
mainfrom
mundane-blowfish
Aug 2, 2026
Merged

skevetter merged 1 commit into
mainfrom
mundane-blowfish

Conversation

@skevetter

@skevetter skevetter commented Aug 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • The desktop app's workspace_status IPC handler hardcoded a 5s --timeout for devsy workspace status, far tighter than the CLI's own 30s default.
  • On slower providers (remote/SSH-backed, first boot, busy Docker daemon) the container status check can exceed 5s, causing the status call to error out and skip the in-progress "Provisioning" override.
  • The renderer's status poller (fetchStatuses in workspaces.ts) silently swallows that failure and keeps the last cached status, so the workspace list/detail pages can get stuck showing a stale "NotFound" badge instead of the real status.
  • Bumped the timeout to 15s to give the check realistic headroom to complete.

Summary by CodeRabbit

  • Bug Fixes
    • Increased the workspace status check timeout to 15 seconds, allowing more time for the CLI to respond successfully.

A too-tight 5s timeout on the workspace_status IPC call could cause
container status checks to time out on slower providers, causing the
call to error out and skip the provisioning-status override. The
frontend silently swallows that failure and keeps the previously
cached status, so the workspace detail/list pages could get stuck
showing a stale "NotFound" badge instead of the real status.
@netlify

netlify Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit ada5773
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a6e7532674f0400085fb3d5

@coderabbitai

coderabbitai Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 07a12d6a-9461-4cd8-b75e-3a336488131e

📥 Commits

Reviewing files that changed from the base of the PR and between 533da0b and ada5773.

📒 Files selected for processing (1)
  • desktop/src/main/ipc.ts

📝 Walkthrough

Walkthrough

The workspace_status IPC handler now invokes the CLI with a 15-second timeout instead of a 5-second timeout.

Changes

Workspace status timeout

Layer / File(s) Summary
Increase workspace status CLI timeout
desktop/src/main/ipc.ts
The workspace_status CLI timeout increases from 5s to 15s.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the timeout increase for the workspace_status IPC handler.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit ada5773
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a6e75321ccbd800085ff176

@skevetter
skevetter marked this pull request as ready for review August 1, 2026 23:31
@skevetter
skevetter merged commit 40142f8 into main Aug 2, 2026
28 checks passed
@skevetter
skevetter deleted the mundane-blowfish branch August 2, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant