Skip to content

fix(agentcontainer): format VS Code settings log - #1315

Merged
skevetter merged 1 commit into
mainfrom
fix/format-vscode-settings-log
Sep 29, 2026
Merged

skevetter merged 1 commit into
mainfrom
fix/format-vscode-settings-log

Conversation

@skevetter

@skevetter skevetter commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Log VS Code settings as indented JSON so nested objects and lists are readable and map keys are stable.
  • Return settings serialization errors through the existing setup error path.
  • Add formatter tests for nested values, stable output, and serialization errors.

Validation

  • mise exec -- go test ./cmd/internal/agentcontainer
  • mise exec -- task cli:lint:ci
  • coderabbit review --committed --base main --agent (0 findings)

Summary by CodeRabbit

  • Improvements
    • VS Code settings are now easier to read in diagnostic logs. The settings sent to the VS Code server remain unchanged.
    • Errors encountered while formatting settings for logging are now reported instead of being silently ignored.

@netlify

netlify Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 808b4c8
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6abb4e91f1f99d0008af4f34

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c2cbf33f-7c86-4a6a-8cc4-cee35119b313

📥 Commits

Reviewing files that changed from the base of the PR and between 59f51ce and 808b4c8.

📒 Files selected for processing (2)
  • cmd/internal/agentcontainer/setup.go
  • cmd/internal/agentcontainer/setup_internal_test.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

setupVSCode now logs settings as indented JSON and returns formatting errors. The settings sent to the VS Code server remain compact JSON. Tests cover formatted output, repeatability, and serialization errors.

Changes

VS Code settings formatting

Layer / File(s) Summary
Format settings and test output
cmd/internal/agentcontainer/setup.go, cmd/internal/agentcontainer/setup_internal_test.go
A new helper formats settings as indented JSON for the debug log. setupVSCode returns formatting errors, while server settings serialization remains unchanged. Tests check sorted, indented output, repeatability, and error handling.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 808b4

VS Code settings are more readable in debug logs, while server-facing settings remain unchanged. No actionable merge risk is established; the change is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: formatting the VS Code settings log.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 808b4c8
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6abb4e9157148200084c81d0

@skevetter
skevetter marked this pull request as ready for review September 29, 2026 16:10
@mergify

mergify Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter
skevetter merged commit 804fd6f into main Sep 29, 2026
90 checks passed
@skevetter
skevetter deleted the fix/format-vscode-settings-log branch September 29, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant