test(secrets): isolate unowned recovery backend probes

[skevetter]

Root cause

TestStore_UnownedWithoutBackendStateIsRecoverable used newSystemBackendRegistry, so the unit test's first Get probed the runner's real macOS login keychain for the fixed default/LEGACY key. Under the GoReleaser -race package run, that key could exist in the shared keychain from another test invocation or runner state. The registry then repaired the legacy entry to BackendKeyring, and Get returned the stored value instead of the expected actionable unowned error. Attempts 1 and 2 of Actions run 35633642155 both failed with expected actionable unowned error, got <nil> (0.68s and 1.16s), confirming an external-state dependency rather than a timing assertion.

Fix

Use the existing in-memory keyring and file backend fakes for this recovery behavior test. Both are deliberately empty for the initial Get, and the same registry then verifies that Set and Get recover the entry without touching a platform keychain.

No retry or sleep is added. Product code and the system-backend probe coverage remain unchanged.

Validation

• go test ./pkg/secrets -run '^TestStore_UnownedWithoutBackendStateIsRecoverable$' -count=20
• go test -race ./pkg/secrets -run '^TestStore_UnownedWithoutBackendStateIsRecoverable$' -count=10
• go test ./pkg/secrets
• git diff --check

[netlify]

✅ Deploy Preview for devsydev canceled.

Name	Link
🔨 Latest commit	f123f31
🔍 Latest deploy log	https://app.netlify.com/projects/devsydev/deploys/6ab1861b1f03c80008752af0

[coderabbitai]

Warning

Review limit reached

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5bb5ad7b-3fbc-434c-833f-7b75ecb75e8e

📥 Commits

Reviewing files that changed from the base of the PR and between bfbaba7 and f123f31.

📒 Files selected for processing (1)

• pkg/secrets/store_internal_test.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[netlify]

✅ Deploy Preview for images-devsy-sh canceled.

Name	Link
🔨 Latest commit	f123f31
🔍 Latest deploy log	https://app.netlify.com/projects/images-devsy-sh/deploys/6ab1861b2f5df20008fad2ca

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request