fix(desktop): remove broken settings section navigation - #1251
Conversation
Signed-off-by: Samuel K <skevetter@pm.me>
Signed-off-by: Samuel K <skevetter@pm.me>
✅ Deploy Preview for devsydev canceled.
|
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
|
@greptileai review |
|
|
Tick the box to add this pull request to the merge queue (same as
|
Summary
Cause
The app uses
svelte-spa-router, where#/...owns the URL hash. Plainhref="#general"section links replace that router hash, so the router falls back to Dashboard instead of scrolling.Validation
npm --prefix desktop run checknpm --prefix desktop test -- --run src/renderer/src/pages/SettingsPage.test.ts src/renderer/src/lib/components/update/UpdatesPanel.test.tsnpm --prefix desktop run electron:build