Skip to content

refactor(desktop): simplify settings layout - #1249

Merged
skevetter merged 3 commits into
mainfrom
feat/desktop-settings-cleanup
Sep 20, 2026
Merged

skevetter merged 3 commits into
mainfrom
feat/desktop-settings-cleanup

Conversation

@skevetter

@skevetter skevetter commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • replace four separate settings tabs with one scannable page and responsive section navigation
  • align the Settings heading and content hierarchy with the main desktop pages
  • reduce duplicate update metadata and release-channel copy while preserving all update states, actions, errors, warnings, and confirmation flows
  • rename Experimental to Advanced while keeping the warning and every control

Validation

  • npm --prefix desktop run check
  • npm --prefix desktop test -- --run src/renderer/src/lib/components/update/UpdatesPanel.test.ts
  • npm --prefix desktop run electron:build
  • Electron render inspected at 1200 px and 640 px widths under Xvfb

Summary by CodeRabbit

  • Improvements

    • Settings are now presented as a single scrollable page with anchored General, Appearance, Updates, and Advanced sections.
    • Settings controls and update information adapt more smoothly to smaller screens.
    • Update status information has been simplified for easier scanning.
    • Release channel options now use a cleaner, more compact presentation.
    • Update behavior and version details are displayed in a streamlined layout.
  • Changes

    • The color-scheme selector has been removed from Appearance settings.
    • The Experimental section is now labeled Advanced.

Signed-off-by: Samuel K <skevetter@pm.me>
Signed-off-by: Samuel K <skevetter@pm.me>
Signed-off-by: Samuel K <skevetter@pm.me>
@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 9524b485-80af-4c1a-90af-aec4851e56d5

📥 Commits

Reviewing files that changed from the base of the PR and between c6473e4 and 0f6d846.

📒 Files selected for processing (3)
  • desktop/src/renderer/src/lib/components/update/UpdatesPanel.svelte
  • desktop/src/renderer/src/lib/components/update/UpdatesPanel.test.ts
  • desktop/src/renderer/src/pages/SettingsPage.svelte

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The settings page now uses anchored sections instead of tabs. The update panel has simpler copy, responsive layouts, reduced status details, and a plain version footer. Related test assertions match the revised update text.

Changes

Settings and update UI

Layer / File(s) Summary
Update panel presentation
desktop/src/renderer/src/lib/components/update/UpdatesPanel.svelte, desktop/src/renderer/src/lib/components/update/UpdatesPanel.test.ts
The update panel uses responsive status and behavior layouts, simpler channel and version content, and revised available-update assertions.
Anchored settings sections
desktop/src/renderer/src/pages/SettingsPage.svelte
The settings page removes tab navigation and color-scheme controls. It adds anchored General, Appearance, Updates, and Advanced sections with responsive layouts.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 0f6d8

The settings and update UI changes have no identified merge-blocking issue.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: simplifying the desktop Settings layout. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 0f6d846
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6aaf7e4cb1335e0008c55541

@netlify

netlify Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 0f6d846
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6aaf7e4cbfd4ac0008f1d507

@skevetter
skevetter marked this pull request as ready for review September 20, 2026 06:59
@mergify

mergify Bot commented Sep 20, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@skevetter
skevetter merged commit df0cf02 into main Sep 20, 2026
31 checks passed
@skevetter
skevetter deleted the feat/desktop-settings-cleanup branch September 20, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant