You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Devcontainer entrypoint scripts were built as multi-line Go string literals joined
with \n. In the generated docker-compose.devcontainer.*.yml files this forces yaml.v3 into block-scalar (|) style, so the entrypoint shows up as several
log lines (with stray blank lines) instead of one, and is more prone to
newline/formatting issues when passed through sh -c.
What
Added joinShellStatements(...string) string (pkg/devcontainer/single.go),
joining shell statements with ; instead of embedded newlines.
DefaultEntrypoint, GetStartScript (single.go), and buildOverrideEntrypoint (compose_up.go) now build their scripts from an
explicit []string of statements and flatten them with the helper, so the
scripts — and therefore the compose YAML entrypoint field — render on a
single line.
Factored the shared "echo Container started" / trap "exit 0" 15 / /bin/sh literals into package constants (startScriptEchoStatement, startScriptTrapStatement, shShellPath) to avoid duplicating them across single.go and compose_up.go.
Preserved the "$$@" compose-escaping in buildOverrideEntrypoint: the
compose CLI interpolates $VAR/${VAR} when it parses the override file,
so the literal $@ passthrough must stay doubled to survive that
round-trip (see composeLabelEscaper in the same file). The result is
behavior-preserving, single-line output.
compose_test.go: TestBuildOverrideEntrypointSingleLine, TestBuildOverrideEntrypointComposeEscapesExecPassthrough (regression test
for the $$@ escaping), TestBuildOverrideEntrypointAppendsUserEntrypoint, TestBuildOverrideEntrypointKeepsDefaultEntrypointReachable.
@skevetter, you've reached your PR review limit, so we couldn't start this review.
Next review available in:56 seconds
Limit details: You’ve used all 1 included review currently available under your plan.
You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Build entrypoint scripts by joining statements with '; ' instead of
embedded newlines. Single-line scripts survive log lines and YAML
string scalars intact (no more block-scalar '|' with blank lines).
Preserves the '$$@' compose-YAML escaping required by docker
compose's variable interpolation on the entrypoint round-trip; the
prior draft of this refactor had regressed that to a single '$',
which would break exec passthrough under compose.
Signed-off-by: Samuel K <skevetter@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Devcontainer entrypoint scripts were built as multi-line Go string literals joined
with
\n. In the generateddocker-compose.devcontainer.*.ymlfiles this forcesyaml.v3into block-scalar (|) style, so the entrypoint shows up as severallog lines (with stray blank lines) instead of one, and is more prone to
newline/formatting issues when passed through
sh -c.What
joinShellStatements(...string) string(pkg/devcontainer/single.go),joining shell statements with
;instead of embedded newlines.DefaultEntrypoint,GetStartScript(single.go), andbuildOverrideEntrypoint(compose_up.go) now build their scripts from anexplicit
[]stringof statements and flatten them with the helper, so thescripts — and therefore the compose YAML entrypoint field — render on a
single line.
"echo Container started"/trap "exit 0" 15//bin/shliterals into package constants (startScriptEchoStatement,startScriptTrapStatement,shShellPath) to avoid duplicating them acrosssingle.goandcompose_up.go."$$@"compose-escaping inbuildOverrideEntrypoint: thecompose CLI interpolates
$VAR/${VAR}when it parses the override file,so the literal
$@passthrough must stay doubled to survive thatround-trip (see
composeLabelEscaperin the same file). The result isbehavior-preserving, single-line output.
Tests
single_test.go:TestDefaultEntrypointSingleLine,TestGetStartScriptSingleLine,TestGetStartScriptPreservesStatementOrder,TestGetStartScriptOmitsEmptyStatementForNoCustomEntrypoints.compose_test.go:TestBuildOverrideEntrypointSingleLine,TestBuildOverrideEntrypointComposeEscapesExecPassthrough(regression testfor the
$$@escaping),TestBuildOverrideEntrypointAppendsUserEntrypoint,TestBuildOverrideEntrypointKeepsDefaultEntrypointReachable.Signed-off-by: Samuel K skevetter@pm.me