Skip to content

test(netstat): cover parseAddr edge cases #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 2 commits into from
Aug 18, 2026
Merged

test(netstat): cover parseAddr edge cases #1045

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c516f8f
test(netstat): cover parseAddr edge cases
devsy-app[bot] Aug 14, 2026
e7bafa3
Merge branch 'main' into pkg-tunnel-network/netstat-parseaddr-tests
skevetter Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions pkg/netstat/netstat_util_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,3 +113,35 @@ func (s *NetstatUtilTestSuite) TestGetProcName() {
})
}
}

func (s *NetstatUtilTestSuite) TestParseAddr() {
tests := []struct {
name string
input string
wantIP string
wantPort uint16
wantErr bool
}{
{"ipv4 loopback", "0100007F:0050", "127.0.0.1", 80, false},
{"ipv6 any", "00000000000000000000000000000000:0016", "::", 22, false},
{"missing port", "foo", "", 0, true},
{"bad ip length", "ZZ:0050", "", 0, true},
{"invalid ipv4 hex", "0100007G:0050", "", 0, true},
{"invalid port hex", "0100007F:zzzz", "", 0, true},
}

for _, tt := range tests {
s.Run(tt.name, func() {
got, err := parseAddr(tt.input)
if tt.wantErr {
assert.Error(s.T(), err)
assert.Nil(s.T(), got)
return
}
require.NoError(s.T(), err)
require.NotNil(s.T(), got)
assert.Equal(s.T(), tt.wantIP, got.IP.String())
assert.Equal(s.T(), tt.wantPort, got.Port)
})
}
}
Loading