Repository navigation
fix(cmd/workspace): lowercase log strings - #1024
Merged
Merged
Conversation
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lowers the casing of log strings in
cmd/workspace(and itsup/subpackage) to comply with the repo convention that log messages are lowercase, including lowercase acronyms (e.g.gpg tunnel,ssh tunnel,ide).cmd/ subdirectory reviewed
cmd/workspace/— includingbuild.go,exec.go,gpg_tunnel.go,import.go,port_forward.go,set_ide.go,ssh.go, andup/{configure,tunnel,up,up_client}.go.Issue found
cmd/workspacecontained 22 log calls whose message strings started with an uppercase letter (e.g."Reusing existing machine","Error deleting workspace") or embedded capitalized acronyms (e.g."GPG tunnel is running","starting SSH tunnel for workspace","set IDE for workspace"). The AGENTS.md convention is lowercase log strings, and the existingcmd-reviewerprecedent (PR #1008,cmd/feature) also lowercases acronyms in log prose.Minimal change
Purely mechanical casing changes to log message strings — no behavioral changes, no import changes, no logic touched. Structured key/value log fields (
workspaceId=,cmd.IDE=references) were left unchanged, as were pre-existing arguments passed to non-format log calls. 11 files, 28 lines changed.Examples:
log.Errorf("Error deleting workspace: %v", ...)→log.Errorf("error deleting workspace: %v", ...)log.Debugf("GPG tunnel is running, skipping setup")→log.Debugf("gpg tunnel is running, skipping setup")log.Info("Starting SSH tunnel for workspace")→log.Info("starting ssh tunnel for workspace")log.Infof("set IDE for workspace %q to %q", ...)→log.Infof("set ide for workspace %q to %q", ...)Verification performed
task cli:format— clean (no formatting changes needed).task cli:lint:ci— 0 issues (--new-from-patchagainst origin/main).task cli:test—cmd/...packages pass (cmd/workspaceandcmd/workspace/upok). The only failing suite ispkg/git(TestRepoCloneArgsThroughRunner,TestRepoCloneFromInfoBranch,TestRepoCloneFromInfoHelper) — this is the documented known pre-existing failure onorigin/main, reproduced identically with my changes stashed, and my change does not touchpkg/git.This PR was created by an AI agent as part of an automated daily CLI review job.