Skip to content

fix(cmd/workspace): lowercase log strings - #1024

Merged
skevetter merged 1 commit into
mainfrom
cmd-reviewer/workspace-lowercase-logs
Aug 13, 2026
Merged

skevetter merged 1 commit into
mainfrom
cmd-reviewer/workspace-lowercase-logs

Conversation

@devsy-app

@devsy-app devsy-app Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Lowers the casing of log strings in cmd/workspace (and its up/ subpackage) to comply with the repo convention that log messages are lowercase, including lowercase acronyms (e.g. gpg tunnel, ssh tunnel, ide).

cmd/ subdirectory reviewed

cmd/workspace/ — including build.go, exec.go, gpg_tunnel.go, import.go, port_forward.go, set_ide.go, ssh.go, and up/{configure,tunnel,up,up_client}.go.

Issue found

cmd/workspace contained 22 log calls whose message strings started with an uppercase letter (e.g. "Reusing existing machine", "Error deleting workspace") or embedded capitalized acronyms (e.g. "GPG tunnel is running", "starting SSH tunnel for workspace", "set IDE for workspace"). The AGENTS.md convention is lowercase log strings, and the existing cmd-reviewer precedent (PR #1008, cmd/feature) also lowercases acronyms in log prose.

Minimal change

Purely mechanical casing changes to log message strings — no behavioral changes, no import changes, no logic touched. Structured key/value log fields (workspaceId=, cmd.IDE= references) were left unchanged, as were pre-existing arguments passed to non-format log calls. 11 files, 28 lines changed.

Examples:

  • log.Errorf("Error deleting workspace: %v", ...) → log.Errorf("error deleting workspace: %v", ...)
  • log.Debugf("GPG tunnel is running, skipping setup") → log.Debugf("gpg tunnel is running, skipping setup")
  • log.Info("Starting SSH tunnel for workspace") → log.Info("starting ssh tunnel for workspace")
  • log.Infof("set IDE for workspace %q to %q", ...) → log.Infof("set ide for workspace %q to %q", ...)

Verification performed

  • task cli:format — clean (no formatting changes needed).
  • task cli:lint:ci — 0 issues (--new-from-patch against origin/main).
  • task cli:test — cmd/... packages pass (cmd/workspace and cmd/workspace/up ok). The only failing suite is pkg/git (TestRepoCloneArgsThroughRunner, TestRepoCloneFromInfoBranch, TestRepoCloneFromInfoHelper) — this is the documented known pre-existing failure on origin/main, reproduced identically with my changes stashed, and my change does not touch pkg/git.

This PR was created by an AI agent as part of an automated daily CLI review job.

@netlify

netlify Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit dd009d8
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a7d9522e7923d000832997d

@netlify

netlify Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit dd009d8
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a7d9522d0c976000807fd53

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@skevetter
skevetter marked this pull request as ready for review August 13, 2026 13:29
@skevetter
skevetter merged commit b8e7d77 into main Aug 13, 2026
67 checks passed
@skevetter
skevetter deleted the cmd-reviewer/workspace-lowercase-logs branch August 13, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant