Repository navigation
fix(ui): show notif dismiss btn on keyboard focus - #1019
Merged
Merged
Conversation
Add focus-visible:opacity-100 to the notification dismiss button in NotificationHistory.svelte. The button was opacity-0 and only revealed on mouse hover, so keyboard users could not see it when focused. aria-label was already present; this adds the missing visible focus indicator.
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
desktop/src/renderer/src/lib/components/layout/NotificationHistory.svelte, the per-notification dismiss button is hidden by default (opacity-0) and only revealed on mouse hover (group-hover/item:opacity-60,hover:!opacity-100). The button is focusable and has anaria-label, but there is nofocus-visiblereveal, so a keyboard user who tabs to it cannot see it. This is an accessibility gap for the notification dismiss action.Change
Added
focus-visible:opacity-100to the dismiss button's class list so the button becomes fully visible when it receives keyboard focus, matching the existing hover-reveal behaviour for mouse users. One class token added; no logic, markup, or behaviour change.Why it's safe / reviewable in <15 min
focus-visible) already available in the project's utility set, consistent with the surrounding hover-based reveal pattern.aria-label="Dismiss notification"was already present, so the only missing piece was the visible focus indicator.Verification
cd desktop && npm install --ignore-scripts— succeeded.cd desktop && npm run check(svelte-check / TypeScript) —svelte-check found 0 errors and 0 warnings.cd desktop && npx vitest run—38 passed (38),328 passed (328).task cli:format— clean.task cli:lint:ci—0 issues.task cli:test— passes except the known pre-existingpkg/gitTestRepoClone*failures (stale assertion on origin/main, unrelated to this change which only touches a desktop Svelte component).This PR was created by an AI agent as part of an automated daily UI polish job.