Repository navigation
fix: drop redundant else in getIngressHost - #1018
Merged
Merged
Conversation
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codefactor issue
6a77b13d5b1ec0b4ee20c436cmd/pro/start.go:1941Problem
In
getIngressHost, theif err != nil { return "", err }block is followed by anelse { ... }whose body only runs when theifdid not return. Since theifbranchalways returns on the error path, the
elseis redundant and forces the success-pathbody one indentation level deeper. Codefactor flags this as a maintainability issue.
Fix
Dropped the redundant
elseand outdented its block (the// find hostfor-loop thatreturns
rule.Host). Behavior is unchanged: the success path still runs only whenerr == nil.if err != nil { return "", err - } else { - // find host - for _, rule := range ingress.Spec.Rules { - return rule.Host, nil - } + } + // find host + for _, rule := range ingress.Spec.Rules { + return rule.Host, nil }Only this one block was changed; the sibling branch in the same function is out of scope
(one issue per run).
Verification
go build ./cmd/pro/— compiles cleanly.task cli:format— clean.task cli:lint:ci— 0 new issues (new-from-patch againstorigin/main).task cli:test— passes except the known pre-existingpkg/gitfailures(
TestRepoCloneArgsThroughRunner,TestRepoCloneFromInfoBranch,TestRepoCloneFromInfoHelper) that fail onorigin/mainalready and are unrelated tothis change (this PR does not touch
pkg/git).This PR was created by an AI agent as part of an automated daily Codefactor issue fix job.