You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds unit tests for pkg/ssh/keys.go covering the three key-management helpers: GetPrivateKeyRawBase, GetPublicKeyBase, and GetHostKeyBase.
Package reviewed
pkg/ssh (SSH/git/credentials category).
Issue found
pkg/ssh/keys.go had no test coverage for its key generation/persistence helpers. The functions generate an ED25519 key pair, write the private key (PEM, 0600) and public key (authorized-keys format, 0644) to disk, and return their base paths. Edge cases — idempotency across repeated calls, public/private correspondence, file permissions, and missing base-directory creation — were unverified.
Change
New file pkg/ssh/keys_test.go with table-driven tests asserting:
key generation produces a valid PEM private key and an authorized-keys public key
the public key corresponds to the private key (fingerprint match)
private key files are 0600, public key files are 0644
generation is idempotent: calling twice returns the same paths without error
a missing base directory is created automatically
No behavioral changes to production code; tests only.
Verification
task cli:lint:ci — 0 new issues
task cli:test — focused pkg/ssh tests pass (known pre-existing pkg/gitTestRepoClone* failures on origin/main are unrelated and not touched by this change)
This PR was created by an AI agent as part of an automated daily package review job.
Add unit tests for pkg/ssh/keys.go covering GetPrivateKeyRawBase,
GetPublicKeyBase, and GetHostKeyBase. Tests assert key generation
produces valid PEM/authorized-key pairs, that public and private keys
correspond, file permissions are 0600/0644, key generation is
idempotent across calls, and missing base directories are created.
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for
pkg/ssh/keys.gocovering the three key-management helpers:GetPrivateKeyRawBase,GetPublicKeyBase, andGetHostKeyBase.Package reviewed
pkg/ssh(SSH/git/credentials category).Issue found
pkg/ssh/keys.gohad no test coverage for its key generation/persistence helpers. The functions generate an ED25519 key pair, write the private key (PEM, 0600) and public key (authorized-keys format, 0644) to disk, and return their base paths. Edge cases — idempotency across repeated calls, public/private correspondence, file permissions, and missing base-directory creation — were unverified.Change
New file
pkg/ssh/keys_test.gowith table-driven tests asserting:0600, public key files are0644No behavioral changes to production code; tests only.
Verification
task cli:lint:ci— 0 new issuestask cli:test— focusedpkg/sshtests pass (known pre-existingpkg/gitTestRepoClone*failures on origin/main are unrelated and not touched by this change)This PR was created by an AI agent as part of an automated daily package review job.