Repository navigation
style: extract debian codename constants - #1009
Merged
Merged
Conversation
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces repeated Debian release codename string literals in
pkg/dockerinstallwith named constants, resolvinggoconstfindings fromgolangci-lint. No behavioral change.Linter + category
golangci-lint(Go,.golangci.yaml)goconst— repeated string constants that should be extracted to named constantsFindings fixed
goconstflagged repeated Debian release codename string literals ("trixie","bookworm","bullseye","buster","stretch","jessie") used acrosspkg/dockerinstallin the version map and the corresponding test assertions.Count: 6 codename literals centralized into named constants (
CodenameTrixie,CodenameBookworm,CodenameBullseye,CodenameBuster,CodenameStretch,CodenameJessie) and applied across the package.Files changed (4)
pkg/dockerinstall/constants.go— added codename constantspkg/dockerinstall/detector.go—versionMapnow references constants instead of string literalspkg/dockerinstall/detector_test.go— test assertions use constants instead of string literalspkg/dockerinstall/validator_test.go— updated literal reference to useCodenameStretchFix method
Mechanical extraction of repeated string literals into named package-level constants, then updating call/test sites to reference them. No logic or behavior changed.
Verification
task cli:format— passed (exit 0)task cli:lint:ci— passed, 0 new issuestask cli:test—pkg/dockerinstalltests passpkg/gitTestRepoClone*failures are pre-existing on cleanorigin/main(stale assertion, unrelated to this change â�� not touched by this PR)Constraints
No behavioral changes � formatting/lint fixes only. No linters disabled.
This PR was created by an AI agent as part of an automated daily lint fix job.