Repository navigation
ci: migrate app-id to client-id in workflows - #1007
Merged
Merged
Conversation
Replace the deprecated 'app-id' input of actions/create-github-app-token@v3 with the supported 'client-id' input across cla.yml, pr-ci.yml, release.yml, and act.yml. The pinned action (v3.1.0) deprecated 'app-id' in favor of 'client-id'; the two inputs are interchangeable (client-id takes precedence, app-id is a fallback) and use the same secret (DEVSY_GITHUB_APP_ID). workflow-approval.yml already uses client-id, so this aligns the remaining workflows and removes the deprecation warning emitted in CI runs.
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the deprecated
app-idinput ofactions/create-github-app-token@v3(pinned atbcd2ba49, v3.1.0) with the supportedclient-idinput across the four remaining workflows:act.yml,cla.yml,pr-ci.yml, andrelease.yml.Problem
actions/create-github-app-token@v3deprecated theapp-idinput in favor ofclient-id. The deprecated input emits a deprecation warning in CI runs and will eventually be removed. Five workflows in this repo use the action;workflow-approval.ymlalready migrated toclient-id, leaving the other four emitting the deprecation warning on every run that creates an app token.Inspected runs
ci: cap e2e jobs with timeout-minutes (#991)— Pull Request workflow, run id31531277926, conclusionsuccess, 11m53s (2026-08-12).ci: cap e2e jobs with timeout-minutes (#991)— Desktop CI, run id31531277934, conclusionsuccess, 21s (2026-08-11).Both invoke
actions/create-github-app-tokenwithapp-id, triggering the deprecation warning.Change
Four single-line edits (
app-id→client-id), one per workflow, each in thewith:block of thecreate-github-app-tokenstep:.github/workflows/act.ymlapp-id→client-id.github/workflows/cla.ymlapp-id→client-id.github/workflows/pr-ci.ymlapp-id→client-id.github/workflows/release.ymlapp-id→client-idNo other lines touched. Total diff: +4/-4.
Why this is safe
client-idandapp-idare interchangeable per the action's docs:client-idtakes precedence andapp-idis now a fallback. The value (${{ secrets.DEVSY_GITHUB_APP_ID }}) is unchanged — the same secret is used for both inputs, since the App ID resolves identically either way.workflow-approval.ymlalready usesclient-idwith the same secret, proving the configuration works in production.client-id; noapp-id:inputs remain (grep -rn "app-id:" .github/workflows/*.ymlreturns nothing).Validation
python3 -c "import yaml; yaml.safe_load(open('<file>'))"→YAML OKfor all four files.task cli:format→ exit 0 (no Go files touched; formatting gate clean).task cli:lint:ci→ 0 issues.task cli:test→ passes except the known pre-existingpkg/gitTestRepoClone*failures (stale--config filter.lfs.*assertions when git-lfs is absent), unrelated to this change and failing onorigin/mainalready.act --listvalidation was skipped; validated via YAML parse instead.This PR was created by an AI agent as part of an automated daily CI optimization job.