fix(providers): link omo panes resumed with --session-id to their sessions - #46
Merged
Conversation
…sions extractExternalResumeSessionId matched only the pi-derived --resume|-r form for omo, but omo's canonical continuation flag is --session-id (its --resume takes no value and opens a picker) -- the same fact #43 established for the headless runtime in server/pi-cli.ts. A tmux pane started with `omo --session-id <id>` therefore never linked back to its transcript session. omo now tries --session-id first and keeps the --resume fallback; omp is unchanged and never accepts --session-id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
extractExternalResumeSessionIdmatched only the pi-derived--resume|-rform for omo, but omo's canonical continuation flag is--session-id— the same fact #43 established for the headless runtime inserver/pi-cli.ts(omo's--resumetakes no value and opens an interactive picker, so no id ever appears in argv for that form).A tmux pane started with
omo --session-id <id>therefore never linked back to its transcript session in discovery.How
--session-id(space and=forms) first and keeps the pi--resumefallback for wrappers that pass it through.--session-idflag, and the new regex is not applied to it.Verification
extractExternalResumeSessionId links omo panes started with --session-id(both argv forms, picker form stays null, omp isolation).external-cli-sessions.service.test.ts: 57/57 pass.npm run typecheck+ targeted eslint clean.