ci: exempt version.go from the test-presence check#3
Merged
Conversation
Release Please bumps `internal/version/version.go` (its `var Number`, via the x-release-please-version marker) on every release PR, with no other code and nothing to test. The test-presence gate flagged those PRs as "Go source changed without any updates under tests/", blocking releases. Exempt internal/version/version.go from the check; it holds only the version string. Real code changes elsewhere are still enforced. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Alex Wilkerson John <alex.w@linktr.ee>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Release Please PR (
release-please--branches--main--components--merger) fails thetest presenceCI job:Release Please bumps
internal/version/version.go(itsvar Number, via thex-release-please-versionmarker) on every release PR, along withCHANGELOG.md— no other code, and nothing testable.scripts/ci/check_test_presence.shtreatsversion.goas ordinary Go source and blocks the release.Fix
Exempt
internal/version/version.gofrom the test-presence check (alongside the existing_test.goanddoc.goexemptions). It holds only the version string. Real code changes elsewhere are still enforced.Verified locally:
version.go+CHANGELOG.md) → no code changes flagged → passesinternal/scan/scan.go) → still flagged as requiring testsversion.godropped, real file kept🤖 Generated with Claude Code