Skip to content

fix(configurator): unify confirmation ownership and split app modules - #328

Merged
devmobasa merged 19 commits into
mainfrom
fix/configurator-confirmation-ownership
Aug 4, 2026
Merged

fix(configurator): unify confirmation ownership and split app modules#328
devmobasa merged 19 commits into
mainfrom
fix/configurator-confirmation-ownership

Conversation

@devmobasa

Copy link
Copy Markdown
Owner

Summary

  • Represent Defaults Reset and Session Clear as one typed pending confirmation, ensuring only one destructive action can be armed at a time.
  • Make confirmation replacement, cancellation, reload invalidation, and Escape handling consistent across both flows.
  • Preserve newer status feedback when canceling an older confirmation.
  • Restore keyboard focus after Session Clear is confirmed or canceled.
  • Add regression coverage for ownership, stale events, missing sessions, status preservation, and focus handoff.
  • Split oversized configurator pages, update handlers, and component wiring into focused modules.
  • Replace production use super::* imports with explicit module dependencies.

Structure

The refactor separates:

  • Session catalog, cards, settings, and tests
  • UI settings sections
  • Drawing settings sections
  • Daemon controls and status
  • Boards and render-profile sections
  • Preset rows and color handling
  • Configuration load, save, migration, defaults, status, and tests
  • Drawing/UI field updates
  • Component shell, view, and effects wiring

These are structural moves intended to preserve existing behavior outside the confirmation fixes.

@devmobasa
devmobasa merged commit 16f2bac into main Aug 4, 2026
2 checks passed
@devmobasa
devmobasa deleted the fix/configurator-confirmation-ownership branch August 4, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant