fix(core): wire persistence cleanup into startup — completes #218#421
Merged
Conversation
#420 added and unit-tested persistence.cleanup() (prunes orphaned snapshot files from worktrees that no longer run) but never called it, so orphans still accumulated. Wire it into guard startup (best-effort, optional-chained so test doubles are unaffected) and assert the wiring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#420 implemented and unit-tested
persistence.cleanup()(prunes orphaned state snapshots left by worktrees that no longer run, by TTL/mtime, preserving the current/fresh file), but it was never called — so the orphaned-files accumulation that #218 reports still happened. This wires it into guard startup (right after rehydrate), best-effort and optional-chained so an injected test persistence (which omitscleanup) is unaffected and a cleanup failure can never break startup.Completes the fix for #218 (auto-closed by #420; this lands the missing call).
Verification
node --test "tests/*.test.mjs"→ 650 pass, 0 fail.createGuardinvokespersistence.cleanup()exactly once at startup.