Add special LaunchAppStep handler into executeNestedStep#63
Open
zcsteele wants to merge 1 commit intodevicelab-dev:mainfrom
Open
Add special LaunchAppStep handler into executeNestedStep#63zcsteele wants to merge 1 commit intodevicelab-dev:mainfrom
zcsteele wants to merge 1 commit intodevicelab-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I have a possible solution to #62 implemented here, which I have verified in the following conditions:
Type of Change
Changes Made
Added a new custom step condition to
executeNestedStepfor step type*flow.LaunchAppStep. This case block checks to see if AppID is blank, which is true if thelaunchAppstep in the flow does not include an explicit app id.If the AppID is blank, it is set using the default value from the flow configuration.
Related Issues
Fixes #62
Testing
make test)Checklist
Additional Notes
I could use some quick pointers on where/how I should add test cases to validate this behavior