chore (deps): bump go version to v1.26.4#1667
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughGo toolchain references were updated from 1.26.3 to 1.26.4 across ChangesGo 1.26.4 Toolchain Bump
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Trivy (0.69.3)Trivy execution failed: 2026-07-10T12:39:10Z FATAL Fatal error run error: fs scan error: scan error: scan failed: failed analysis: post analysis error: post analysis error: cloudformation scan error: fs filter error: fs filter error: walk error range error: stat .golangci.yml: no such file or directory: range error: stat .golangci.yml: no such file or directory Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi! I'm che-ai-assistant — I help with your pull requests. Available commands:
|
rohanKanojia
requested review from
akurinnoy,
btjd,
dkwon17 and
ibuziuk
as code owners
|
/che-ai-assistant ok-pr-readiness Review is complete. Please check the review comments below. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.ci/oci.Dockerfile:
- Line 28: Update the comment in the Dockerfile so it matches the current source
of truth from go.mod: the stale reference to go 1.26.0 should be replaced with
the actual toolchain directive version go1.26.4. Keep the comment aligned with
the dependency/version guidance by referring to the toolchain requirement
declared in go.mod, not an old version string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b766e12d-579c-4376-9013-dc109c97e22b
📒 Files selected for processing (7)
.ci/oci.Dockerfile.github/workflows/code-coverage.yml.github/workflows/pr.yml.github/workflows/release.ymlbuild/Dockerfilego.modproject-clone/Dockerfile
| SHELL ["/bin/bash", "-c"] | ||
|
|
||
| # Install Go 1.26.3 to satisfy go.mod toolchain requirement (go 1.26.0) | ||
| # Install Go 1.26.4 to satisfy go.mod toolchain requirement (go 1.26.0) |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the stale toolchain reference in the comment.
Line 28 still says the "toolchain requirement" is go 1.26.0, but go.mod now declares toolchain go1.26.4. Please point the comment at the actual source-of-truth directive.
As per coding guidelines, "Use versions from go.mod as the source of truth for Go, Kubernetes, controller-runtime, and Devfile dependency versions."
Suggested fix
-# Install Go 1.26.4 to satisfy go.mod toolchain requirement (go 1.26.0)
+# Install Go 1.26.4 to satisfy the go.mod toolchain directive📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Install Go 1.26.4 to satisfy go.mod toolchain requirement (go 1.26.0) | |
| # Install Go 1.26.4 to satisfy the go.mod toolchain directive |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.ci/oci.Dockerfile at line 28, Update the comment in the Dockerfile so it
matches the current source of truth from go.mod: the stale reference to go
1.26.0 should be replaced with the actual toolchain directive version go1.26.4.
Keep the comment aligned with the dependency/version guidance by referring to
the toolchain requirement declared in go.mod, not an old version string.
Source: Coding guidelines
PR Readiness Assessment: PR #1667 — chore (deps): bump go version to v1.26.4Repository: devfile/devworkspace-operator
Overall: NEEDS WORK Missing Information
What's Good
Assessment completed by ok-pr-readiness |
rohanKanojia
force-pushed
the
pr/bump-go-version-1-26-4
branch
2 times, most recently
from
fd0cca5 to
5f5b72f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: btjd, rohanKanojia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Update Go toolchain to 1.26.4 and use Red Hat UBI9 go-toolset:1.26.4-1783628461 with digest sha256:78c30e4fb77d1fa049d3bff5d9da1b5d77cc0ed96a2c30e6c4905380d3580462 Assisted-by: Auto Signed-off-by: Rohan Kumar <rohaan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
rohanKanojia
force-pushed
the
pr/bump-go-version-1-26-4
branch
from
5f5b72f to
96f2f6c
Compare
|
New changes are detected. LGTM label has been removed. |
3 participants
What does this PR do?
go.modtoolchain directive togo1.26.4pr.yml,code-coverage.yml,release.yml) to use Go 1.26.4.ci/oci.Dockerfileto install Go 1.26.4build/Dockerfileandproject-clone/Dockerfileto Red Hat UBI9 go-toolset9.8-1783442369pinned by digest:sha256:c451b481b8f26205bd34eab98a3566a559466cc8de125b4e7057a13f53d96cd3What issues does this PR fix or reference?
Fixes CVEs:
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with CheSummary by CodeRabbit
Summary by CodeRabbit