chore(deps): bump go version to v1.25.9#1617
Conversation
|
Skipping CI for Draft Pull Request. |
📝 WalkthroughWalkthroughThis pull request updates the Go toolchain version from 1.25.8 to 1.25.9 across CI/CD pipelines, build configurations, and the go.mod file. All changes are patch-level version bumps with no functional modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rohanKanojia
force-pushed
the
pr/go-toolset-update-1-25-9
branch
2 times, most recently
from
050089f to
c85e305
Compare
Update Go toolchain to 1.25.9 and use Red Hat UBI9 go-toolset:1.25-1777043046 with digest sha256:35f08031de19eb51d6b35ed62c6357d3529bc69a8db65cf623ea5f0b44051999 Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/go-toolset-update-1-25-9
branch
from
c85e305 to
de337a5
Compare
rohanKanojia
requested review from
akurinnoy,
dkwon17 and
ibuziuk
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (3)
.ci/oci.Dockerfile (2)
18-24: Remove the duplicateENVblock.Lines 18-20 and 22-24 declare the exact same three environment variables (
GO_VERSION,GOROOT,PATH). The second block is a no-op and just adds maintenance overhead — note that this PR already had to updateGO_VERSIONin two places. Consolidating now will prevent the two from drifting on the next bump.♻️ Proposed cleanup
ENV GO_VERSION=1.25.9 ENV GOROOT=/usr/local/go ENV PATH=$GOROOT/bin:$PATH -ENV GO_VERSION=1.25.9 -ENV GOROOT=/usr/local/go -ENV PATH=$GOROOT/bin:$PATH - SHELL ["/bin/bash", "-c"]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.ci/oci.Dockerfile around lines 18 - 24, Duplicate ENV block setting GO_VERSION, GOROOT and PATH appears twice; remove the redundant second block so these variables are declared only once. Locate the duplicate ENV statements for GO_VERSION, GOROOT and PATH in the Dockerfile and delete the repeated three-line block (keep a single declaration), ensuring future version bumps only need to change the remaining GO_VERSION/GOROOT/PATH lines.
28-28: Nit: keep the comment in sync withGO_VERSION.The comment hard-codes
1.25.9, while the install command below uses the${GO_VERSION}env var. On the next patch bump this comment will need to be updated separately (and was updated separately in this PR). Consider rewording to avoid repeating the literal version, e.g.# Install Go (version pinned via GO_VERSION) to satisfy go.mod toolchain requirement (go 1.25.0).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.ci/oci.Dockerfile at line 28, The comment above the Go install step hard-codes "1.25.9" and can drift from the actual variable used; update the comment to avoid repeating a literal version and reference the GO_VERSION variable instead (e.g., "Install Go (version pinned via GO_VERSION) to satisfy go.mod toolchain requirement (go 1.25.0)") so it remains accurate when ${GO_VERSION} changes; locate the comment near the GO_VERSION usage in the .ci/oci.Dockerfile and replace the hard-coded version text accordingly.build/Dockerfile (1)
19-19: Consider using1.25.9-1777043046for better readability.The tag changed from
1.25.8-1775651161to1.25-1777043046, dropping the patch version from the human-readable portion. While the SHA256 digest remains the true pin and guarantees deterministic behavior, a reader reviewing the Dockerfile can no longer tell at a glance which patch version this stage uses. The registry exposes1.25.9-1777043046pointing to the same image, offering patch-specific clarity without losing the digest pin.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@build/Dockerfile` at line 19, Update the FROM image tag to include the patch version for readability while keeping the digest pin: replace the current tag portion "1.25-1777043046" in the FROM line (the builder stage) with the human-readable "1.25.9-1777043046" so the digest remains the source of truth but the Dockerfile shows the specific patch version.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.ci/oci.Dockerfile:
- Around line 18-24: Duplicate ENV block setting GO_VERSION, GOROOT and PATH
appears twice; remove the redundant second block so these variables are declared
only once. Locate the duplicate ENV statements for GO_VERSION, GOROOT and PATH
in the Dockerfile and delete the repeated three-line block (keep a single
declaration), ensuring future version bumps only need to change the remaining
GO_VERSION/GOROOT/PATH lines.
- Line 28: The comment above the Go install step hard-codes "1.25.9" and can
drift from the actual variable used; update the comment to avoid repeating a
literal version and reference the GO_VERSION variable instead (e.g., "Install Go
(version pinned via GO_VERSION) to satisfy go.mod toolchain requirement (go
1.25.0)") so it remains accurate when ${GO_VERSION} changes; locate the comment
near the GO_VERSION usage in the .ci/oci.Dockerfile and replace the hard-coded
version text accordingly.
In `@build/Dockerfile`:
- Line 19: Update the FROM image tag to include the patch version for
readability while keeping the digest pin: replace the current tag portion
"1.25-1777043046" in the FROM line (the builder stage) with the human-readable
"1.25.9-1777043046" so the digest remains the source of truth but the Dockerfile
shows the specific patch version.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: af002cc9-f3f0-4236-8e44-686820f0c1a1
📒 Files selected for processing (7)
.ci/oci.Dockerfile.github/workflows/code-coverage.yml.github/workflows/pr.yml.github/workflows/release.ymlbuild/Dockerfilego.modproject-clone/Dockerfile
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, rohanKanojia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 participants
What does this PR do?
Update Go toolchain to
1.25.9go-toolset:1.25-1777043046What issues does this PR fix or reference?
This PR aims to resolve these CVE(s) :
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with CheSummary by CodeRabbit