Repository navigation
refactor(core) #400: slim down StateMachine trait — move non-protocol methods to server layer #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoshuaChi
wants to merge
19
commits into
main
Choose a base branch
from
refactor/400-refactor-state-machine
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
370ad2f
refactor #400: Remove StateMachine::start, len and is_empty
JoshuaChi 4a51f1a
refactor #400: Remove StateMachine::is_running; report state machine …
JoshuaChi 24aa6eb
refactor #400: Take the state machine by value; route embedded reads …
JoshuaChi 907cebb
refactor #400: Make snapshot checksums an engine responsibility
JoshuaChi b74bc59
fix #400: Make snapshot checksums cover every file of the snapshot di…
JoshuaChi 42dedd0
refactor #400: Trim StateMachine to what the engine calls; persist sn…
JoshuaChi 0a589bd
refactor #400: The engine decides which snapshots are installed
JoshuaChi 0bb1184
refactor #400: The engine records the snapshots it holds
JoshuaChi b0eaf0d
fix #400: Export RocksDB snapshots from one frozen view of the database
JoshuaChi 1057507
fix #400: Label snapshots with the position the state machine exports
JoshuaChi 6e63696
fix #400: Stop the read path before the state machine is closed; slim…
JoshuaChi de03144
fix #400: Keep the applied position together with the data across a c…
JoshuaChi e53ba63
refactor #400: Remove StateMachine::reset; builders start tests on em…
JoshuaChi 06b47d3
fix #400: integration test fix
JoshuaChi 6096399
fix #400: Address PR review feedback
JoshuaChi e42e6fa
refactor #400: StateMachine methods return StateMachineError
JoshuaChi c735c21
refactor #400: Drop From<Error> for StateMachineError, convert explic…
JoshuaChi 5afde8e
refactor #400: State machine helpers return StateMachineError directly
JoshuaChi 2b7ad0c
refactor #400: StateMachine returns std::io::Result; remove StateMach…
JoshuaChi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: deventlab/d-engine
Length of output: 970
Script executed:
Repository: deventlab/d-engine
Length of output: 13547
Correct the
last_applied()return type in the changelog.The changelog says every
StateMachinemethod returnsstd::io::Result.last_applied()returnsLogIddirectly (d-engine-core/src/storage/state_machine.rs:200). An adapter that follows the note fails to compile. Also fix the same wording inMIGRATION_GUIDE.mdline 34.Suggested changelog fix
Committable suggestion