You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: WAL persist failure silently ignored — node must exit on IO error #404
When persist_entries fails in the IO thread (buffered_raft_log.rs:892),
d-engine only logs an error. The Raft loop receives no signal, the node
continues serving, and in Level 2 (MemFirst) mode clients may have already
received ACKs for entries that were never persisted — silent data loss.
Fix: on persist_entries failure, send a fatal/shutdown signal to the Raft
loop so the node exits cleanly, consistent with etcd's behavior.
Affected: buffered_raft_log.rs IO thread, both durable and MemFirst modes.
Activity
JoshuaChi commentedon Oct 2, 2026
fixed in #447 (1d65aae)
persist/fsync failure → mark_poisoned_and_notify → InternalEvent::FatalError → Raft loop exits
tests: drain_fsync_test.rs (persist / fsync failure poisons)