docs(xlsx): measure horizontal bar-chart category-label baselines, document blockers (#1621) - #1763
Merged
developer0hye merged 1 commit intoSep 16, 2026
Conversation
…cument blockers (#1621) Confirms native quantizes each row's vertical baseline to a whole sheet point (the issue's own 6 expense-chart values, divided by the 0.78 fit scale, are exact integers), and extends that to a second chart (income, different row pitch) and three font sizes -- 18 measured baselines total, all whole sheet points. Falsifies the obvious fix: neither a flat floor nor a flat round of office2pdf's own current continuous baseline reproduces native across both charts with one shared rule. floor matches every expense row but only 1 of 5 income rows; round matches every income row but only 3 of 6 expense rows. Documents a more promising but still incomplete decomposition (native = round(row's geometric centre) + a coarsely size-quantized term, mirroring line_category_baseline_pt's already-shipped ascent rounding) that fits the income chart exactly across all three sizes, but is off by one sheet point on 5 of 6 expense rows for a reason not yet isolated -- most likely the plot rectangle's own vertical edges needing independent whole-point snapping before dividing into row bands, which a category-count probe (not yet run) would confirm or rule out. No runtime code changes; assets/validation/issue-1621/ only. Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
developer0hye
deleted the
docs/issue-1621-bar-category-label-y-derivation
branch
September 16, 2026 18:04
This was referenced Sep 16, 2026
pull Bot
pushed a commit
to RadaKichenin/office2pdf
that referenced
this pull request
Sep 16, 2026
…elines (developer0hye#1621) Extends the developer0hye#1621 baseline-placement investigation with the category-count probe the prior session (developer0hye#1763) flagged as the needed next step. - Discovers and documents that a chart-XML-cache-only category-count patch is a complete no-op against native Excel: it re-derives the income chart's categories from xl/workbook.xml's defined-name array literal and its values from a live formula range, both outside the chart part, and overwrites the chart's own cache on open regardless of what it says. - Adds build_category_count_probe.py, which patches both parts together to actually change category count in native Excel, and uses it to collect a new native measurement: the income chart widened to 6 categories. - Refines the working model from "round + chart-specific K" to "floor + font-size-only K", which now reproduces 18 of 24 measured rows across three independent geometric configurations, narrowing the open question to a specific plot-rectangle edge-row effect. - Falsifies one specific edge-row hypothesis (independent whole-point snapping of the plot rectangle's own edges). No runtime code changes -- assets/validation/issue-1621/ only. Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
floornor a flatroundof office2pdf's own current continuous baseline reproduces native across both charts with one shared rule.floormatches every expense-chart row but only 1 of 5 income-chart rows;roundmatches every income-chart row but only 3 of 6 expense-chart rows.round(row's geometric centre) + a coarsely size-quantized term, mirroringline_category_baseline_pt's already-shipped ascent rounding) that fits the income chart exactly across all three sizes, but is off by one sheet point on 5 of 6 expense rows for a reason not yet isolated — most likely the plot rectangle's own vertical edges needing independent whole-point snapping before dividing into row bands. A category-count probe (not yet run — more invasive than the size probe here, since it needs to rewrite both the category and value caches together) would confirm or rule this out.assets/validation/issue-1621/only.Related issue
Related: #1621, #1756
Testing
python3 assets/validation/issue-1621/verify_measurements.pyexits 0, confirming the whole-sheet-point quantization and the floor/round split against both native datasets.python3 scripts/probe_harness.py assets/validation/issue-1621/category-size-probe.json --backend officereproduces the 8pt/14pt income-chart native rows recorded inmeasurements.json..rs/runtime config changes — tests skipped per project convention for non-runtime changes.Visual impact
assets/validation/issue-1621/measurement data, a probe spec, and a verification script; no chart rendering or codegen path is touched, so there is no rendered PDF change to audit.Checklist
Signed-off-byline🤖 Generated with Claude Code