Skip to content

docs(xlsx): confirm line-legend marker floor rule, document blockers (#1618) - #1754

Merged
developer0hye merged 1 commit into
mainfrom
docs/issue-1618-legend-marker-offset-derivation
Sep 16, 2026
Merged

developer0hye merged 1 commit into
mainfrom
docs/issue-1618-legend-marker-offset-derivation

Conversation

@developer0hye

@developer0hye developer0hye commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Summary

Related issue

Related: #1618, #1617, #1753

Testing

  • python3 assets/validation/issue-1618/verify_floor_phase_rule.py exits 0, confirming the floor rule against all 32 rows of both native datasets.
  • python3 assets/validation/issue-1618/measure_legend_line_x.py 0.82 <pdf>... reproduces the x0/x1/mid values committed in native-legend-line-key-measurements.json.
  • Documentation-freshness review completed (one inaccurate cross-dataset claim found and fixed before this commit).
  • No .rs/runtime config changes — tests skipped per project convention for non-runtime changes.

Visual impact

  • No rendered PDF change
  • Rendered PDF change or visual evidence added
  • Reason: Adds only assets/validation/issue-1618/ measurement scripts and native-export data used to derive and verify the placement rule; no chart rendering or codegen path is touched, so there is no rendered PDF change to audit.

Checklist

  • Commits include a Signed-off-by line
  • PR scope contains one root cause
  • Remaining converter or harness deviations each reference an open issue

🤖 Generated with Claude Code

…blocks shipping it (#1618)

Native Excel seats a line-legend key's marker on a whole chart point via
floor(target) - (size mod 2)/2, the same algebra WorksheetMarkerPlacement
already uses for plot markers. Verified against 9 legend sizes across two
independent native export batches (4 gathered fresh for this issue), on
both axes, with the floor-vs-round discriminating rows named explicitly.

A general fix is blocked: x is algebraically reachable but boundary-
sensitive under the Segoe UI substitute this machine renders; y depends on
office2pdf's own sample-line position, which drifts up to 2.87pt from
native past the font size this issue was filed at (a separate root cause,
filed as #1753) and, even once that's fixed, needs Rust to own an absolute
position Typst's inline layout currently resolves on its own. Landing a fix
that only holds at the one calibrated size would be exactly the overfit
this project's TDD rule forbids.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
@developer0hye
developer0hye merged commit c3bfafd into main Sep 16, 2026
34 of 35 checks passed
@developer0hye
developer0hye deleted the docs/issue-1618-legend-marker-offset-derivation branch September 16, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant