fix(xlsx): lay chart content out on the frame's fitted sheet origin

[developer0hye]

File submission policy

Before attaching or committing files, read the submission policy.

• Any submitted sample files or attachments satisfy the submission policy, or none are submitted. The source is the public Gift Budget and Tracker1.xlsx misc issues #982 attachment already tracked in the repository; only derived evidence is added.

Summary

An anchored worksheet chart's content (plot, gridlines, value and category labels, legend, markers) was laid out from the converter's physical page origin while its frame was painted on Excel's fitted sheet-space origin (#1542). At the gift workbook's 0.82 fit scale the two origins differ by 0.854 sheet points, and the #1250 chrome model had absorbed that gap: a 10.146pt top inset and an 11.853pt bottom pad reproduced the native plot only there. On the unscaled control, where the origins coincide, the whole plot printed 0.854pt high and its whole-point gridlines re-rounded one point off native.

Native Excel for Mac 16.112 exports of the same chart at 100% and at 0.82 (the fresh exports recorded for #1598 and #1600), and the 0.78 export measured for #1272, all put the plot 11 sheet points inside the frame at the top and keep an 11pt bottom edge pad, the flat inset Excel already uses on the right. The chart content now shares the frame's origin, the two vertical insets are that 11pt, the bottom-legend seat is re-based by the same 0.853pt, and the sheet_paint_offset_pt plumbing that kept the content on the old origin (write_offset_paint_box_start, WorksheetMarkerPlacement::plot_offset) is removed. The unscaled control's gridlines, value labels, category labels and legend now trace at the native page coordinates; the fitted chart keeps its matched vertical geometry and its x moves 0.185pt onto the native plot edge.

Related: #1607

Related issue

Related: #1607. Filed from this audit: #1745 (series not clipped to the whole-point plot rectangle) and #1746 (unscaled centred tile keeps a fractional horizontal origin). The January and June column edges are recorded on #1735.

Testing

• cargo test --locked -p office2pdf --lib: 3082 passed.
• New compiled-paint regression worksheet_column_plot_edges_follow_native_at_every_print_scale pins the plot's top and bottom rules at the native page coordinates for both 1.0 (143.0126 / 391.1924pt) and 0.82 (126.2903 / 329.7977pt); fitted_drawing_frames_carry_chart_text_with_the_frame, ..._carry_the_plot_edges_with_the_frame and ..._carry_the_legend_key_with_the_frame replace the XLSX charts: fitted drawing foreground keeps the physical page origin #1542 tests that pinned the old split; the Charts: an anchored sheet chart's plot area is 1.27pt short vertically, so its gridlines drift up to 1.14pt off the export's #1250/Charts: worksheet chart gridlines ignore Excel whole-point snapping #1471/Charts: a fitted worksheet column remains 0.53pt too narrow #1543 chart-local tests are re-based onto the frame Excel paints.
• cargo +1.97 clippy --locked --workspace --all-targets -- -D warnings, cargo fmt --all --check and git diff --check pass.
• Unscaled control against the native export: compare_layout.py --audit --fine-shift 0.5 --noise-floor 0.5 page 2 fine shifts 14 → 1 (budgeted, XLSX: each line of a multi-line wrapped centred cell keeps Typst's centring where Excel seats it on the whole-point grid #1738), rectangle geometry findings 4 → 1 (XLSX: unscaled column-chart bar left edge lands one sheet point right of native #1735); page 3 unchanged (its two 0.225pt band-edge findings are pre-existing on main, XLSX: an unscaled centred sheet keeps a fractional horizontal origin where Excel prints each tile on a whole sheet point #1746). Strict 300 DPI cluster gates: page 2 84/84 and page 3 9/9 dispositioned (XLSX: unscaled column-chart bar left edge lands one sheet point right of native #1735, XLSX: worksheet chart series are not clipped to Excel's whole-point plot rectangle, so a zero-value line paints over the category axis #1745, XLSX: an unscaled centred sheet keeps a fractional horizontal origin where Excel prints each tile on a whole sheet point #1746-remainder glyph fragments and accepted renderer classes).
• Fitted original against its native export, page 2: 0 fine shifts and 0 rectangle geometry findings before and after; page-2 gridline y unchanged to 0.001pt.
• compare_text_layer.py: no class injected; the content residual is the clipped chart runs of XLSX: chart text clipped on a print tile stays in the neighbouring tile's text layer #1736.
• Documentation freshness reviewer: PASS.

Visual impact

• No rendered PDF change
• Rendered PDF change or visual evidence added
• Reason: Moves every anchored worksheet chart's content onto the frame's fitted sheet origin and corrects the vertical plot insets.

Visual audit

• Issue: XLSX: unscaled worksheet column-chart content uses an incorrect vertical inset #1607
• Fixture: tests/fixtures/xlsx/issue_1603_gift_budget.xlsx with xl/worksheets/sheet2.xml pageSetUpPr/@fitToPage changed from true to false (controlled package SHA-256 af4160ca276c3add9e3100f80c8df7156afbdf6ec7a0090161e015a7ccf5d5cb); native export SHA-256 0935ca38e497a657d2f972fb7ddfc3163cf69e8edfe6d79d230202b5db5d7bfa
• Page(s): 2, 3
• Renderer and DPI: pdftoppm at 300 DPI; ImageMagick 5% fuzz
• Evidence mode: fix
• Layout audit report: assets/bugfixes/issue-1607/layout-audit.json
• Render cluster reports: assets/bugfixes/issue-1607/render-clusters-page-2.json, assets/bugfixes/issue-1607/render-clusters-page-3.json
• Reference exporter differences: None
• Fine-detail threshold: 0.5pt
• Layout audit page count: Pass
• Layout audit text flow: XLSX: chart text clipped on a print tile stays in the neighbouring tile's text layer #1736
• Layout audit visible fills: Pass
• Layout audit rectangle geometry: XLSX: unscaled column-chart bar left edge lands one sheet point right of native #1735, XLSX: an unscaled centred sheet keeps a fractional horizontal origin where Excel prints each tile on a whole sheet point #1746
• Layout audit large shifts: Pass
• Layout audit fine shifts: XLSX: each line of a multi-line wrapped centred cell keeps Typst's centring where Excel seats it on the whole-point grid #1738
• New follow-up issues found in this audit: XLSX: worksheet chart series are not clipped to Excel's whole-point plot rectangle, so a zero-value line paints over the category axis #1745, XLSX: an unscaled centred sheet keeps a fractional horizontal origin where Excel prints each tile on a whole sheet point #1746
• Model vision findings: Full pages 2 and 3, the 5% diffs and matched 300 DPI crops were inspected. On page 2 the eleven grey gridlines, the $0..$200 value labels, the Jan..Sep category labels and the legend row now sit on the native rows (the before image had every one of them 0.85pt high); the diff keeps only glyph-edge outlines on the table text, the native raster marker sprites against our vector discs, the January, June and July column left edges one sheet point right (XLSX: unscaled column-chart bar left edge lands one sheet point right of native #1735), and the zero-value series runs where native cuts the 2.24pt stroke at its whole-point plot clip and shows the grey axis under it while we paint the full stroke (XLSX: worksheet chart series are not clipped to Excel's whole-point plot rectangle, so a zero-value line paints over the category axis #1745). On page 3 the eleven gridlines, the Oct..Dec labels and the three markers match; the two title bands' right edges end 0.225pt short (XLSX: an unscaled centred sheet keeps a fractional horizontal origin where Excel prints each tile on a whole sheet point #1746) and the Oct..Dec zero-value run shows the same unclipped stroke (XLSX: worksheet chart series are not clipped to Excel's whole-point plot rectangle, so a zero-value line paints over the category axis #1745). The budgeted header line sits 0.51pt left (XLSX: each line of a multi-line wrapped centred cell keeps Typst's centring where Excel seats it on the whole-point grid #1738). Font faces, weights and colours match on every crop.
• GT: assets/bugfixes/issue-1607/gt.jpg
• Before: assets/bugfixes/issue-1607/before.jpg
• After: assets/bugfixes/issue-1607/after.jpg
• Native: None
• Compare: None

Visual comparison

GT	Before	After

Required inspection

• Rendered all evidence at 150 DPI or higher
• Stored progressive JPEG quality 86 assets with metadata stripped
• Used Codex/Claude vision to inspect the full GT/output pages, diff, and matched crops
• Inspected matched region crops at full resolution
• Ran compare_layout.py --audit --fine-shift PT and dispositioned every fine/large text-instance shift, rectangle geometry deviation, painted-text visibility mismatch, and visible-fill occlusion
• Ran compare_render.py --cluster-report PATH --strict-clusters and dispositioned every material 5% fuzz diff cluster by explicit ID
• Inventoried hairlines and border dash styles
• Inventoried font weight, italic, and underline emphasis

Deviation audit

Check	Result
Page count/order	Matches GT: three pages in source order.
Element presence	Matches GT: eleven gridlines, axis, five columns, series line, markers, legend and labels on both tiles.
Position/size	Remaining: #1746 (tile origin, 0.225..0.28pt), #1735 (column left edges), #1738 (budgeted); the plot top/bottom, gridlines, value and category labels and legend rows are fixed onto the native rows.
Rotation/flip	Matches GT.
Fill	Matches GT: column, band and legend-key fills keep colour and coverage.
Stroke/border	Remaining: #1745 (zero-value series runs painted over the axis). The eleven 0.74pt gridlines and the 2.24pt series stroke otherwise match in width, colour and dash style (solid).
Shape outline geometry	Remaining: #1735 (January, June and July column left edges one sheet point right). Native raster marker sprites against vector discs at the same centres are accepted shape-edge antialiasing.
Text content	Remaining: #1736 (clipped chart runs stay in the neighbouring tile's text layer). Visible text matches on both tiles.
Font family/weight/style	Matches GT: Segoe UI chart text, bold occasion cells, regular body text on every crop.
Text color	Matches GT.
Alignment	Remaining: #1738 (second line of the wrapped centred budgeted header). Value labels right-aligned and category labels centred as native.
Line/paragraph spacing	Matches GT: gridline pitch 24/25pt on whole sheet points and the 20pt category-to-legend row pitch.
Clipping/overflow	Remaining: #1745 (series not clipped to the whole-point plot rectangle). The chart ends at the printed sheet edge on page 2 and continues on page 3 as native does.

Checklist

• Commits include a Signed-off-by line
• PR scope contains one root cause
• Remaining converter or harness deviations each reference an open issue

🤖 Generated with Claude Code