feat: Add welcome message - #26
Draft
titouanfreville wants to merge 2 commits into
Draft
Conversation
titouanfreville
force-pushed
the
feature/welcome_message
branch
3 times, most recently
from
May 7, 2021 16:43
e3e59e6 to
25d370e
Compare
- Current code architecture is too heavy for open source project and do not let people easily in if they are not used to it. We decided to refactor it to a simpler base witch can be learned without pre requisites and let you code using your own habits. - Enforce some tools to format code - Add CONTRIBUTING rules and Makefile to ease setup, running && testing This proposition looks a bit heavy for a simple hello world but it should stay clean with more complex usecases. It enforces concern separation as discord part should only filter event before calling correct module entrypoint, dissociate services from modules and allow core feature to stay core ^^
titouanfreville
force-pushed
the
feature/welcome_message
branch
2 times, most recently
from
May 7, 2021 22:10
569ac47 to
2ed41af
Compare
titouanfreville
changed the title
titouanfreville
force-pushed
the
feature/welcome_message
branch
2 times, most recently
from
May 7, 2021 22:13
5cf3538 to
945ae4c
Compare
titouanfreville
marked this pull request as ready for review
May 7, 2021 22:15
titouanfreville
marked this pull request as draft
May 7, 2021 22:15
titouanfreville
force-pushed
the
feature/welcome_message
branch
4 times, most recently
from
May 8, 2021 19:10
22ccc46 to
4f810c4
Compare
As discord server admin, we would like to propose a custom message to welcome any new member. - Add an admin role to discord guild on bot startup - Bot admin can customise message More: - Add bandit check for security issue
titouanfreville
force-pushed
the
feature/welcome_message
branch
from
May 9, 2021 16:38
4f810c4 to
18a03a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discord server admin, we would like to propose a custom message
to welcome any new member.
More: