fix(visits): formalize visit lifecycle and site scoping - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the formalizing visit lifecycle rules and correcting site handling across visit registration and overdue processing.
Changes
RegisterVisitRequest.siteIdinstead of deriving it fromrequestedBy.site.AuthorizationService.assertCovers()as the authorization boundary for visit registration.VisitorProfileandVisitare associated with the resolved target site.CHECKED_INorOVERDUE).CHECKED_INandOVERDUE.CHECKED_OUTand other invalid lifecycle states.OverdueVisitJobto perform a single global lifecycle update rather than iterating through sites without actually scoping the update.Authorization
The registration flow now distinguishes between:
requestedBy- the actor performing the operation.request.siteId- the target site of the operation.targetSite- the resolved domain entity used by the visit and visitor profile.This preserves global
ADMINaccess while keepingMANAGERandSTAFFrestricted to their assigned site.Lifecycle
Only
CHECKED_INandOVERDUEvisits can be checked out.Issue resolution
Closes #43 - Resolve target site for visit creation
Closes #41 - Fix OverdueVisitJob to Scope Processing by Site