Repository navigation
Conversation
…orage-verify-benchmark-runtime-5665
…orage-verify-benchmark-runtime-5665
…orage-verify-benchmark-runtime-5665
…orage-verify-benchmark-runtime-5665
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
✅
|
Contributor
✅
|
Code coverage overviewLanguages: Go Go / code-coverage/go
Line coverage data for the main branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
…orage-verify-benchmark-runtime-5665 # Conflicts: # scripts/migrate-longhorn-v2/testdata/retirement-fence-proof/runtime-admission.json
…orage-verify-benchmark-runtime-5665
devantler
added a commit
that referenced
this pull request
Nov 10, 2026
…orage-verify-benchmark-runtime-5665
devantler
added a commit
that referenced
this pull request
Nov 10, 2026
devantler
added a commit
that referenced
this pull request
Nov 10, 2026
Contributor
Author
@coderabbitai review |
Contributor
Action not completed
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Author
@codex review for ownership and native cleanup safety for Longhorn V1 benchmark storage |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The V1 benchmark uses disposable storage. Cleanup must prove that the run still owns that storage and that Longhorn can retire it safely before the migration can rely on the benchmark.
What
Bind each benchmark to its verified runtime and original storage. Require the serving APIs and instance managers to confirm the retirement safeguards before the workflow removes its scratch storage. Preserve the run evidence when a safeguard cannot be verified.
Part of #5665