Repository navigation
fix: align work location cards and show the current VM in the launcher - #444
Merged
Merged
Conversation
iililiiilili
marked this pull request as ready for review
November 4, 2026 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes an issue where adding saved VMs produced uneven cards and large empty space around Basic server in Work environment settings. The selected location also appeared separately in the chat header instead of inside the Work location button.
Related: #408 (saved VM switching, already merged). Based on current main
628c932d2360c676f7107ba2bb4a0693b9aa0bbd.Why This Change Was Made
Basic server and every saved VM share one horizontal row. The dialog grows with the location count within the desktop viewport; extra locations scroll horizontally. Card bounds and connection actions align, and long names wrap inside their cards. The stable Work location button contains the authoritative selected location and keeps the existing lazy settings owner, refresh events, and error handling.
User Impact
One, two, or three VMs appear beside Basic server without dropping a card into another row. Users see their current named VM inside Work location while keeping their unsent chat draft and existing connection/settings behavior.
Evidence
0.166.0-alpha.5.1,gpt-6.1-sol/ medium: scoped-clean through P2, complete, no accepted/actionable findings. Full 16-file patch plus four unchanged owner modules; isolation and final source verification retained.5bdc90da40ced607c3be174f1326e05638d39869e4c569928352a55aa32f376bremain unchanged after fast-forward. Reviewed tree:be2cce72825b0a92b244810785248fff9dbf215c.734587f0c8d2409f27f4556e97b947e4cbf5b856c5f9c6979bcaaa2bc626a0f2; the primary personally inspected the current CI 1-VM, 2-VM, and Korean dark 3-VM desktop captures. Before-fix browser evidence from merged #408.GREEN; PR mergeability isCLEAN. Original draft-event cancellations are superseded by successful ready-event runs.AI-assisted. Production delta: +263/−229 (net +34), consolidating current-location rendering and preserving a stable launcher; tests: +278/−67. No runtime, credential, dependency, protocol, schema, deployment, or merge changes.