Skip to content

fix: align work location cards and show the current VM in the launcher - #444

Merged
iililiiilili merged 1 commit into
mainfrom
fix/work-location-layout
Nov 4, 2026
Merged

iililiiilili merged 1 commit into
mainfrom
fix/work-location-layout

Conversation

@iililiiilili

@iililiiilili iililiiilili commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Fixes an issue where adding saved VMs produced uneven cards and large empty space around Basic server in Work environment settings. The selected location also appeared separately in the chat header instead of inside the Work location button.

Related: #408 (saved VM switching, already merged). Based on current main 628c932d2360c676f7107ba2bb4a0693b9aa0bbd.

Why This Change Was Made

Basic server and every saved VM share one horizontal row. The dialog grows with the location count within the desktop viewport; extra locations scroll horizontally. Card bounds and connection actions align, and long names wrap inside their cards. The stable Work location button contains the authoritative selected location and keeps the existing lazy settings owner, refresh events, and error handling.

User Impact

One, two, or three VMs appear beside Basic server without dropping a card into another row. Users see their current named VM inside Work location while keeping their unsent chat draft and existing connection/settings behavior.

Evidence

  • Fresh canonical AutoReview on Windows, app-bundled Codex CLI 0.166.0-alpha.5.1, gpt-6.1-sol / medium: scoped-clean through P2, complete, no accepted/actionable findings. Full 16-file patch plus four unchanged owner modules; isolation and final source verification retained.
  • Task-owned Ubuntu Linux / Node 24.18.0: final desktop Chromium scenarios passed for PlatformClaw light/English and dark/Korean. Checks cover 0/1/2/3 registrations, one-row equal card geometry, aligned connection actions, direct switching, identical-request failure/retry, and unchanged strict subpixel switch stability. Both current bundles were built by canonical browser setup. Final 34 PNGs and two completed WebMs were retained; primary/independent agents personally inspected all six 1/2/3-count screenshots.
  • UI production tsgo and 21 owning settings/progress unit tests passed. Focused syntax lint, affected styles, formatting, and patch whitespace passed. Prior unchanged-code evidence includes 771 UI tests, 71 focused host tests, i18n verification (5,311 keys), and named-target/footer/two-tab browser scenarios.
  • Latest main changes no UI files; all sixteen verified UI source hashes and patch SHA-256 5bdc90da40ced607c3be174f1326e05638d39869e4c569928352a55aa32f376b remain unchanged after fast-forward. Reviewed tree: be2cce72825b0a92b244810785248fff9dbf215c.
  • Exact-head PlatformClaw CI passed: frozen dependency installation, UI typecheck, type-aware private UI lint, 771 tests in 68 files, i18n verification (5,311 keys), and UI build. Production/test types, upstream UI unit lane, guards, and build artifacts also passed. The completed hosted UI gate fills the prior local OOM/install proof gaps; those failed local attempts remain recorded.
  • Current-head browser evidence includes the final 1/2/3-VM screenshots and recordings. The downloaded 17,992,174-byte ZIP matches GitHub SHA-256 734587f0c8d2409f27f4556e97b947e4cbf5b856c5f9c6979bcaaa2bc626a0f2; the primary personally inspected the current CI 1-VM, 2-VM, and Korean dark 3-VM desktop captures. Before-fix browser evidence from merged #408.
  • Exact-head hosted validation is green: upstream CI, Docker smoke, Security Sensitive Guard, and Dependency Guard. Latest checks: 64 passed, 14 conditional skips, zero failing or pending. All four browser E2E shards, full type-aware lint, production/test types, builds, and compact full Node suite passed. The settings E2E file passed all 14 scenarios; its hosted shard passed 209 tests in 54 files. The native CI watcher ended GREEN; PR mergeability is CLEAN. Original draft-event cancellations are superseded by successful ready-event runs.

AI-assisted. Production delta: +263/−229 (net +34), consolidating current-location rendering and preserving a stable launcher; tests: +278/−67. No runtime, credential, dependency, protocol, schema, deployment, or merge changes.

@iililiiilili
iililiiilili marked this pull request as ready for review November 4, 2026 15:36
@iililiiilili
iililiiilili merged commit 3cd6c8b into main Nov 4, 2026
110 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant