test: add validateEnv unit tests and refactor config for testability

backend/src/config.js

@@ -12,7 +12,9 @@ const schema = z.object({
   VACCINATIONS_CONTRACT_ID: z.string().min(1),
 
   // Backend
-  ADMIN_SECRET_KEY: z.string().min(1),
+  ADMIN_SECRET_KEY: z.string().min(1).refine(v => v.startsWith('S'), {
+    message: 'ADMIN_SECRET_KEY must start with S',
+  }),
   SEP10_SERVER_KEY: z.string().min(1),
   JWT_SECRET: z.string().min(1),
   PORT: z.coerce.number().int().positive().default(4000),
@@ -36,12 +38,23 @@ const schema = z.object({
   DATABASE_PATH: z.string().default('/data/vaccichain.db'),
 });
 
-const result = schema.safeParse(process.env);
-
-if (!result.success) {
-  const missing = result.error.issues.map(i => `  ${i.path[0]}: ${i.message}`).join('\n');
-  console.error(`[config] Missing or invalid environment variables:\n${missing}`);
-  process.exit(1);
+function validateEnv(env) {
+  const result = schema.safeParse(env);
+  if (!result.success) {
+    const missing = result.error.issues.map(i => `  ${i.path[0]}: ${i.message}`).join('\n');
+    throw new Error(`[config] Missing or invalid environment variables:\n${missing}`);
+  }
+  return result.data;
 }
 
-module.exports = result.data;
+const config = (() => {
+  try {
+    return validateEnv(process.env);
+  } catch (err) {
+    console.error(err.message);
+    process.exit(1);
+  }
+})();
+
+module.exports = config;
+module.exports.validateEnv = validateEnv;

backend/tests/config.test.js

@@ -0,0 +1,39 @@
+const { validateEnv } = require('../src/config');
+
+const valid = {
+  HORIZON_URL: 'https://horizon-testnet.stellar.org',
+  SOROBAN_RPC_URL: 'https://soroban-testnet.stellar.org',
+  STELLAR_NETWORK_PASSPHRASE: 'Test SDF Network ; September 2015',
+  VACCINATIONS_CONTRACT_ID: 'CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4',
+  ADMIN_SECRET_KEY: 'STEST000000000000000000000000000000000000000000000000000',
+  SEP10_SERVER_KEY: 'STEST000000000000000000000000000000000000000000000000001',
+  JWT_SECRET: 'test-jwt-secret',
+};
+
+describe('validateEnv', () => {
+  it('passes with all required variables present', () => {
+    expect(() => validateEnv(valid)).not.toThrow();
+  });
+
+  it('throws with the variable name when a required variable is missing', () => {
+    const { HORIZON_URL: _, ...env } = valid;
+    expect(() => validateEnv(env)).toThrow('HORIZON_URL');
+  });
+
+  it('throws a format error when ADMIN_SECRET_KEY does not start with S', () => {
+    expect(() => validateEnv({ ...valid, ADMIN_SECRET_KEY: 'XBADKEY' })).toThrow(
+      'ADMIN_SECRET_KEY'
+    );
+  });
+
+  it('throws when STELLAR_NETWORK is set to an invalid value', () => {
+    expect(() => validateEnv({ ...valid, STELLAR_NETWORK: 'devnet' })).toThrow('STELLAR_NETWORK');
+  });
+
+  it('is callable without side effects (no process.exit)', () => {
+    const exitSpy = jest.spyOn(process, 'exit').mockImplementation(() => {});
+    expect(() => validateEnv({ ...valid, HORIZON_URL: 'not-a-url' })).toThrow();
+    expect(exitSpy).not.toHaveBeenCalled();
+    exitSpy.mockRestore();
+  });
+});