docs: release beta.156 documentation sync#271
Merged
Conversation
There was a problem hiding this comment.
🔍 Vibe Check Review
Context
Documentation synchronization PR updating version badges, provider lists, rate limit defaults, and Skaldleita credential guidance to match beta.155 behavior.
Codebase Patterns I Verified
- Documentation style: Project uses markdown docs with tables, code blocks, and clear section headers (verified in
docs/Configuration.md,docs/FAQ.md) - Provider terminology: References "Skaldleita" alongside Audnexus, OpenLibrary, Google Books, Hardcover (verified in
library_manager/hints.pylayer_1 hint) - Config comments:
config.pyuses inline comments to explain optional fields (verified pattern inDEFAULT_SECRETS) - Version badge format: README uses shields.io badge pattern pointing to CHANGELOG.md
✅ Good
- Focused scope: Only documentation and hint text changes, no logic modifications
- Consistent terminology: Updated references to include "OpenAI-compatible" provider alongside Gemini, OpenRouter, Ollama
- Accurate rate limit docs: Changed from "2000 calls/hour" to "200 requests/hour with range 10-500" which matches
config.py:142("max_requests_per_hour": 200) - Proper credential guidance: Updated
bookdb_api_keycomment from "not required for public endpoints" to "bundled shared key is used when empty" — aligns with beta.155's authenticated endpoint changes noted in CHANGELOG
🚨 Issues Found
No issues found.
📋 Scope Verification
| Documentation Claim | Verified Against | Status |
|---|---|---|
| "beta.155" version in README badge | CHANGELOG.md shows [0.9.0-beta.155] entry |
✅ |
| Provider list includes Skaldleita | hints.py:9 layer_1 mentions "Skaldleita, Audnexus, OpenLibrary, Google Books, and Hardcover" |
✅ |
| Rate limit "200 requests/hour, range 10-500" | config.py:142 has "max_requests_per_hour": 200 |
✅ |
| OpenAI-compatible provider mentioned | hints.py:18 new 'openai_compatible' hint added; config.py:160 comment updated |
✅ |
| Skaldleita shared key guidance | config.py:160 comment changed to "bundled shared key is used when empty" |
✅ |
Scope Status: SCOPE_OK — Documentation changes accurately reflect codebase state and beta.155 changelog entries.
🎯 Verdict
APPROVE
🤖 Ruthless review by vibe-check
There was a problem hiding this comment.
🔍 Vibe Check Review
Context
Documentation-only PR synchronizing version numbers, provider lists, and configuration guidance with the current beta.156 state.
Codebase Patterns I Verified
- Versioning:
app.pycontainsAPP_VERSION = "0.9.0-beta.155"which is updated to0.9.0-beta.156in the diff. - Provider Naming: The codebase uses "Skaldleita" as the primary brand name (e.g.,
library_manager/hints.pyhint'skaldleita': 'Free GPU-powered audio identification service...'), whilebookdbis used internally for the API client (library_manager/providers/bookdb.py). - Rate Limiting:
library_manager/config.pyshows"max_requests_per_hour": 200as the default. - AI Providers:
library_manager/hints.pylistsgemini,openrouter,ollama, and the newopenai_compatiblekey.
✅ Good
- Consistency: Version badges in
README.mdandapp.pyare correctly synchronized to0.9.0-beta.156. - Accuracy: Rate limit documentation in
docs/Configuration.mdnow correctly reflects the code's default of 200 requests/hour (previously documented as 2000, which would have been dangerous). - Clarity:
library_manager/hints.pyupdates accurately describe theopenai_compatibleprovider and the shared Skaldleita credential behavior. - Scope: Changes are strictly limited to documentation and version strings; no logic changes detected.
🚨 Issues Found
No issues found.
📋 Scope Verification
| Issue | Problem | Addressed? | Notes |
|---|---|---|---|
| N/A | Documentation Sync | ✅ | PR title claims synchronization; diff confirms alignment across README, Changelog, Docs, and Hints. |
Scope Status: SCOPE_OK
🎯 Verdict
APPROVE
🤖 Ruthless review by vibe-check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The beta.155 provider implementation was merged, but several current documentation and help-text locations still described beta.153, omitted the generic provider, or listed retired rate limits. Repository CI requires a version bump because configuration/help Python modules changed.
Validation
test-env/test-naming-issues.py(290 passed)test-env/test-ai-providers.py(11 passed)test-env/test-ai-provider-integration.py(4 passed)python -m compileall -q app.py library_managergit diff --check