release: 0.9.0-beta.154 — API key on remaining keyless Skaldleita call sites (#264)#267
Merged
Conversation
…eita call sites api_book_detail, api_author_detail, api_series_detail, and identify_ebook_from_filename still called the Skaldleita API with no headers, guaranteeing 401s against the key-or-401 gate. Each now resolves the API key the same way sibling code does (config / load_secrets with BOOKDB_PUBLIC_KEY fallback) and sends get_signed_headers() + X-API-Key. Version bumped to 0.9.0-beta.154.
…lers fix: Attach API key to remaining keyless Skaldleita call sites (#264)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the single commit merged to develop since beta.153: the #264 completion (PR #266).
Four call sites (
api_book_detail,api_author_detail,api_series_detail,identify_ebook_from_filename) now attachget_signed_headers()+X-API-Keylike all sibling code, instead of sending keyless requests that guaranteed 401s against Skaldleita's key-or-401 gate.Verification (already performed on the PR #266 audit)
Merging closes #264.