Step B.3 (shared half): v0.2.0 — Plugin/Events/Auth/Hub#1
Merged
Conversation
…o v0.2.0
Implements Step B.3 of PHLEX_EXPANSION_PLAN.md (shared half). Adds the
framework-neutral interfaces, value objects, and protocol DTOs the
phlex-server and phlex-hub repositories will consume:
- Phlex\Shared\Plugin\LifecycleInterface (moved from
Phlex\Plugins\Contract\LifecycleInterface in phlex-server)
- Phlex\Shared\Plugin\{Manifest, ManifestType, ManifestValidationError,
EventNameMap} (moved from Phlex\Plugins\* in phlex-server). Validator
logic stays in phlex-server (Phlex\Plugins\Manifest\ManifestSchema).
- Phlex\Shared\Events\{AbstractEvent, Playback\*, Library\*, Auth\*}
(12 readonly event DTOs moved from Phlex\Common\Events\* in phlex-server).
PSR-14 dispatcher wiring stays in phlex-server.
- Phlex\Shared\Auth\JwtClaims (new value object capturing the Phlex JWT
payload shape; consumed by phlex-hub starting Phase C.5).
- Phlex\Shared\Hub\{ClaimRequest, ClaimResponse, ServerInfoDto, HeartbeatDto}
(new placeholder DTOs for the hub claim/heartbeat protocol; consumed
by phlex-hub starting Phase C.1).
- Phlex\Shared\Arr\.gitkeep (namespace reserved for Phase K.1).
Manifest is intentionally non-final so phlex-server's deprecated wrapper
can extend it for one release; documented in the class docblock.
Tests: 104 tests / 200 assertions green. PHPStan level 9, Psalm,
PHPCS PSR-12, composer validate --strict all clean.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the shared half of Step B.3 of
PHLEX_EXPANSION_PLAN.md.Adds the framework-neutral interfaces, value objects, and protocol DTOs that
phlex-server and phlex-hub will consume:
Phlex\Shared\Plugin\LifecycleInterface(moved fromPhlex\Plugins\Contract\LifecycleInterfaceinphlex-server).Phlex\Shared\Plugin\{Manifest, ManifestType, ManifestValidationError, EventNameMap}(moved fromPhlex\Plugins\*). Validator stays inphlex-server(Phlex\Plugins\Manifest\ManifestSchema).Phlex\Shared\Events\{AbstractEvent, Playback\*, Library\*, Auth\*}— 12 readonly event DTOs (moved fromPhlex\Common\Events\*). PSR-14 dispatcher wiring stays inphlex-server.Phlex\Shared\Auth\JwtClaims— new value object capturing the Phlex JWT payload shape; consumed byphlex-hubstarting Phase C.5.Phlex\Shared\Hub\{ClaimRequest, ClaimResponse, ServerInfoDto, HeartbeatDto}— new placeholder DTOs for the hub claim/heartbeat protocol; consumed byphlex-hubstarting Phase C.1.Phlex\Shared\Arr\.gitkeep— namespace reserved for Phase K.1.Manifestis non-finalsophlex-server's deprecated wrapper can extend it for one release; documented in the class docblock.Verification (all green):
[OK] No errorsNo errors found!composer validate --strict: cleancomposer audit --no-dev: no advisoriesThe companion phlex-server PR consumes this release via Composer once v0.2.0 is tagged.