post-O.7 wave 4 (K.1): consume phlex-shared arr clients#80
Merged
Conversation
Plan §4.3 + step K.1 require Sonarr/Radarr/Bazarr/Prowlarr typed clients to live in phlex-shared so both phlex-server and phlex-hub can consume them. Reviewer found them in src/Arr/ here instead. phlex-shared PR #2 moved them to Phlex\Shared\Arr and tagged v0.4.0; this PR consumes that package on the server side. - composer.json requires detain/phlex-shared:^0.4.0 (was ^0.3.0) - composer.lock updated to phlex-shared v0.4.0 - src/Arr/ removed (10 files, ~2000 lines) - tests/unit/Arr/ removed (replaced upstream in phlex-shared) - All Phlex\Arr\* imports rewritten to Phlex\Shared\Arr\* in src/Requests/RequestManager.php, src/Server/Core/Application.php, src/Server/Http/Controllers/Arr/SyncController.php, and the StructuredLogger touch surface. - CustomFormatSyncerTest moved under tests/unit/Server/Arr/ for the server-side wiring that still lives here. Tests: scoped phpunit on Requests/Sync/Arr filters pass against the shared package. Pre-existing LiveTvManagerTest HdHomeRunTunerDriver constructor mismatch is unaffected (predates this branch). Refs PHLEX_EXPANSION_PLAN.md §3 K.1, post-O.7 review. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server-side consumption of the arr clients moved upstream in detain/phlix-shared#2 (v0.4.0). Plan K.1 explicitly required arr clients to live in phlex-shared so phlex-server and phlex-hub can both depend on them.
🤖 Generated with Claude Code