fix/9.1: Wire RelayMessageFramer to shared Relay types#124
Merged
Conversation
Update phlix-server's relay implementation to use shared types from detain/phlix-shared ^0.5.0 for the multiplexed WS relay protocol (Section 9.1 Phase 1). Changes: - composer.json: update detain/phlix-shared constraint to ^0.5.0, add path repository for local dev - RelayMessageFramer.php: implement RelayWireCodecInterface, use shared RelayFrameType enum for new encode/decode methods. Legacy frameRequest/frameResponse/framePing/framePong/parse methods retained as @deprecated for backward compatibility with RelayConsumer (which will be updated in Phase 0.6) - RelayFrame.php: add type-check helper methods for new protocol frame types (isClientConnect, isClientDisconnect, isData, isHeartbeat) using shared RelayFrameType values Ref: phlix-hub/docs/ws-multiplexer-plan.md Section 9.1 Phase 1
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 2 medium |
| Documentation | 3 minor |
| ErrorProne | 1 medium |
| Security | 1 critical 1 high |
| CodeStyle | 9 minor |
🟢 Metrics 32 complexity · 0 duplication
Metric Results Complexity 32 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire
RelayMessageFramerto use shared relay types fromdetain/phlix-shared^0.5.0 for the multiplexed WebSocket relay protocol (Section 9.1 Phase 1).Changes
composer.jsondetain/phlix-sharedconstraint from^0.4.0to^0.5.0src/Hub/RelayMessageFramer.phpPhlix\Shared\Relay\RelayWireCodecInterfaceencode(RelayFrameType, int seq, string payload): string— binary frame encodingencodeHello(string, string): string— JSON text HELLO handshakeencodeHelloAck(string, string): string— JSON text HELLO_ACK handshakedecode(string): ?RelayFrame— binary frame decodingframeRequest,frameResponse,framePing,framePong,parsemethods retained as@deprecatedfor RelayConsumer (updated in Phase 0.6)src/Hub/RelayFrame.phpisClientConnect()— checks forCLIENT_CONNECTframeisClientDisconnect()— checks forCLIENT_DISCONNECTframeisData()— checks forDATAframeisHeartbeat()— checks forHEARTBEATframeDependencies
Requires: detain/phlix-shared#6 (
fix/9.1-shared-relay-types)Verification
parse()methodRelayConsumerupdate in Phase 0.6Related
phlix-hub/docs/ws-multiplexer-plan.md(Section 9.1 Phase 1)detain/phlix-shared#6