Fix PHPStan: integrate getFlacDuration into harvestFlacTags#121
Merged
Conversation
- Created getFlacDurationFromHandle($handle) method to parse FLAC STREAMINFO block from an already-open file handle - Updated harvestFlacTags() to call getFlacDurationFromHandle() instead of inline parsing code, eliminating code duplication - Removed unused getFlacDuration() method as it was redundant - Updated tests to use getFlacDurationFromHandle() instead
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 1 medium |
🟢 Metrics -7 complexity · 0 duplication
Metric Results Complexity -7 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getFlacDurationFromHandle($handle)method to parse FLAC STREAMINFO block from an already-open file handleharvestFlacTags()to callgetFlacDurationFromHandle()instead of inline parsing codegetFlacDuration()method (was redundant after refactoring)Fixes PHPStan error:
getFlacDuration()is unused