fix/2.1: Add path validation and improve MIME detection#118
Merged
Conversation
…obook - Add validateMediaPath() to prevent path traversal attacks - Add finfo-based MIME detection with extension fallback - Update tests to use paths that pass security validation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateMediaPath()helper to prevent path traversal attacks instreamAudiobook()Security Fix
validateMediaPath()method now validates that audiobook files are within allowed media directories (/media/,/mnt/,/data/,/home/)finfofor actual file type detection instead of relying solely on file extension